Module adapter cleanup #9383
Merged
Module adapter cleanup #9383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrect function context Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
requested review from
dbaluta,
jxstelter,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
empty TODO for 4 years, no point in keeping it around. Also if you are doing validation after trusting the data enough to do a memcpy you have already lost. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Now that validate_config has been deleted we can clean up some of the error handling logic here. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
dbaluta
approved these changes
Aug 22, 2024
lyakh
approved these changes
Aug 22, 2024
marcinszkudlinski
approved these changes
Aug 22, 2024
lgirdwood
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup dead code and some typos