xtensa/config/core.h: provide UINT32_C() not just for __ZEPHYR__ #9442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xt-clang uses UINT32_C() without importing it. Commit ef38a0c ("arch: xtensa: core.h: Add define for UINT32_C") added it but only for __ZEPHYR__, add it unconditionally. Provide an alternative, assembly-compatible definition apparently needed by XTOS ACP 7.0 compiled with xt-clang. For C code, simply include <stdint.h> Longer and convoluted story in thesofproject#9413. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
andyross
approved these changes
Sep 5, 2024
Contributor
andyross
left a comment
andyross
left a comment
There was a problem hiding this comment.
Indeed this seems cleaner
saisurya-ch
approved these changes
Sep 5, 2024
Collaborator
Author
|
Unrelated suspend/resume failure in https://sof-ci.01.org/sofpr/PR9442/build7703/devicetest/index.html Usual LNL failures in https://sof-ci.01.org/sofpr/PR9442/build7701/devicetest/index.html Everything else green. |
kv2019i
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xt-clang uses UINT32_C() without importing it. Commit ef38a0c ("arch: xtensa: core.h: Add define for UINT32_C") added it but only for
__ZEPHYR__, add it unconditionally.Provide an alternative, assembly-compatible definition apparently needed by XTOS ACP 7.0 compiled with xt-clang.
For C code, simply include <stdint.h>
Longer and convoluted story in #9413.