Tools: Testbench: Switch testbench to IPC4 mode #9590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
commented
Oct 17, 2024
singalsu
commented
Oct 17, 2024
singalsu
force-pushed
the
testbench_use_ipc4_mode
branch
from
5396065 to
55d8646
Compare
Collaborator
Author
I need to figure out cmake stuff to build it. This patch hard-codes the executable name to sof-testbench4. I'd like to make it dependent on library_defconfig choice. Or better, somehow with scripts/rebuild-testbench.sh build for both ipc versions. But I don't yet now how to achieve it with cmake. |
singalsu
force-pushed
the
testbench_use_ipc4_mode
branch
6 times, most recently
from
b514e09 to
8067d99
Compare
Collaborator
Author
|
Seems the tplg2 build for CI testbench step is now resolved. But this PR depends on #9599 to pass the multiband-DRC test. |
The library_defconfig is changed to CONFIG_IPC_MAJOR_4=y. To prepare release of testbench with SOF the executable name is changed to sof-testbench4 for IPC4. The name is selected based on choice in library_defconfig. The script comp_run.sh for process_test.m and other test scripts is changed to execute the IPC4 testbench version with use of other topology v2 topologies sof-hda-benchmark-<comp><bits>.tplg. the script host-testbench.sh is changed to run tests for component names in IPC4 test topologies. The github workflow is changed due to change in used topologies for the test. The scripts/build-tools.sh need to be executed with "-Y" option to build topology2 files. Also need to use alsatplg from docker. The octave-io package is not needed for this step. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
testbench_use_ipc4_mode
branch
from
8067d99 to
55b8465
Compare
Collaborator
Author
|
All dependencies are now merged, changing this to proposal! |
singalsu
requested review from
cujomalainey,
dbaluta,
kv2019i,
lbetlej,
mmaka1,
plbossart and
ranj063
as code owners
ranj063
approved these changes
Oct 25, 2024
lgirdwood
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library_defconfig is changed to CONFIG_IPC_MAJOR_4=y.
To prepare release of testbench with SOF the executable name is changed to sof-testbench4.
The script comp_run.sh for process_test.m and other test scripts is changed to execute the IPC4 testbench version with use of other topology v2 topologies sof-hda-benchmark-.tplg.
the script host-testbench.sh is changed to run tests for component names in IPC4 test topologies.
TODO: Fix valgrind issue in testbench, fix audio quality issue in config blob for multiband-DRC.