trace: split out trace-soflogger.h and trace-boot.h #9597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SOF trace.h is a bit hard to follow as it mixes frontend and backend definitions. The frontend definitions like tr_info() are needed by all SOF builds. The backends can vary and the application traces can be routed to SOF DMA trace (sof-logger), Zephyr logging subsystem or optionally compiled out when tracing is disabled. Improve readability of the header by moving all definitions related to the sof-logger backend to a separate trace-soflogger.h header file. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
akloniex,
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
approved these changes
Oct 18, 2024
lyakh
approved these changes
Oct 21, 2024
Collaborator
|
@kv2019i this should be a compilation-only change, i.e. if it compiles, it should work, but in principle it's also possible to damage code while copying, so that it still compiles but then fails to run. The CI had too many failures here like https://sof-ci.01.org/sofpr/PR9597/build8890/devicetest/index.html and https://sof-ci.01.org/sofpr/PR9597/build8888/devicetest/index.html (too many 8s supposedly), and the QB failed and https://sof-ci.01.org/sofpr/PR9597/build8889/devicetest/index.html only tested 1 device out of 3, so maybe we should re-test... |
Member
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SOF trace.h is a bit hard to follow as it mixes frontend and backend definitions. The frontend definitions like tr_info() are needed by all SOF builds. The backends can vary and the application traces can be routed to SOF DMA trace (sof-logger), Zephyr logging subsystem or optionally compiled out when tracing is disabled.
Improve readability of the header by moving all definitions related to the sof-logger backend to a separate trace-soflogger.h header file.