app: intel_adsp_a*conf: continue cleanup of board files #9623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group the configuration options per theme, separate SOF and Zephyr Kconfig settings and order the entries in alphabetical order within each group. This makes the board config file much more readable and easy to maintain. No functional change, only reordering the entries. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Group the configuration options per theme, separate SOF and Zephyr Kconfig settings and order the entries in alphabetical order within each group. This makes the board config file much more readable and easy to maintain. No functional change, just reordering the options. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Group the configuration options per theme, separate SOF and Zephyr Kconfig settings and order the entries in alphabetical order within each group. This makes the board config file much more readable and Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Remove old, duplicated options for rimage signing schema from cavs25 and cavs25_tgph config files. No functional change to build as the newer options have taken precedence already before this change. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Continue the cleanup and separate SOF and Zephyr options in the board config file. No functional change, just reordering the options. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Move CONFIG_ZEPHYR_LOG to correct section under SOF logging configuration as this option is not Zephyr but a SOF-side option, despite what its name hints at. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
kv2019i
requested review from
abonislawski,
lyakh,
singalsu,
tmleman and
tobonex
tmleman
approved these changes
Oct 29, 2024
singalsu
approved these changes
Oct 29, 2024
abonislawski
approved these changes
Oct 30, 2024
Collaborator
Author
|
@lgirdwood wrote:
A good idea, probably should have added this. I'll go ahead and merge this still as we got test+review pass and this is ready to go (and the board file changes are evasive). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the template introduce in #9620 and apply this to all Intel board files. Series starts with fresh cleanups for cAVS2.5 and PTL, the a commt to align ACE1.5 to #9620 and a few minor fixes for problems (now much easier to see when the options are grouped like this).