Skip to content

Conversation

@jilaypandya
Copy link
Contributor

this commit refactors dma_driver_api in iterable_section

@sofci
Copy link
Collaborator

sofci commented Dec 4, 2024

Can one of the admins verify this patch?

reply test this please to run this test once

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jilaypandya ! Let's have the CI test this out as well.

@jilaypandya
Copy link
Contributor Author

I think I would need some help to get CI done correctly.

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 5, 2024

@jilaypandya I know what's the problem, SOF doesn't have "device: Add DEVICE_API macros" yet. We are struggling with a series of regressions that has blocked our Zephyr updates, so we are stuck at e59289d89999 for Zephyr. But this should be solved soon, I had almost clean CI with #9705 ... still need one more fix on Zephyr side before we can upgrade (and then your PR should pass SOF CI).

@lyakh
Copy link
Collaborator

lyakh commented Dec 9, 2024

test this please

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 9, 2024

@jilaypandya Can you rebase now? #9712 merged to SOF, so Zephyr should be new enough for this PR to pass CI tests.

this commit refactors dma_driver_api in iterable_section

Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
@jilaypandya
Copy link
Contributor Author

@jilaypandya Can you rebase now? #9712 merged to SOF, so Zephyr should be new enough for this PR to pass CI tests.

Done

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 10, 2024

SOFCI TEST

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 10, 2024

Thank you @jilaypandya , all mandatory now passing, proceeding with merge.

@kv2019i kv2019i merged commit 15f68ec into thesofproject:main Dec 10, 2024
41 of 47 checks passed
@jilaypandya jilaypandya deleted the refactor/linker-dma branch December 17, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants