smart-amp-test: remove obsolete build options #9773
Conversation
|
@abonislawski whats happening with LMDK these days now that we can do llext ? Can we support LMDK APIs and loading via llext ? |
lyakh
requested review from
RanderWang,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
|
@lgirdwood we are only keeping one LMDK module (downmixer) in CI just in case if something change in the future roadmap. But in general it is frozen and we can remove smart-amp |
|
CI: https://sof-ci.01.org/sofpr/PR9773/build10155/devicetest/index.html , https://sof-ci.01.org/sofpr/PR9773/build10157/devicetest/index.html and https://sof-ci.01.org/sofpr/PR9773/build10156/devicetest/index.html - all errors are known: missing test devices and a failure in suspend-resume. |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Mostly ok, but a few suprise code removals that I can't link to smart-amp-test, please see inline
| } >HPSRAM_seg : data_phdr | ||
|
|
||
| .rodata : ALIGN(4096) { | ||
| .rodata : { |
There was a problem hiding this comment.
? Thhis seems very odd in a PR to remove smart-ampt-test
|
@lyakh Can you rebase? |
smart-amp-test was one of the first modules, used as an example for loadable module development. Currently it can be built in 4 ways: - monolithic - as an LMDK native module - as legacy LLEXT - as current LLEXT This commit removes legacy options and only preserves the first and the last options. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
4 participants
smart-amp-test was one of the first modules, used as an example for loadable module development. Currently it can be built in 4 ways:
This commit removes legacy options and only preserves the first and the last possibilities.