This repository was archived by the owner on Jan 17, 2019. It is now read-only.
topology: fix BE DAI id to be set to ID (not index) #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiulipan
suggested changes
Jul 24, 2018
Contributor
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
Please check inline comments about
default_hw_conf_id to make sure hw_config is used by driver
| `SectionHWConfig."'$1$2`" {' | ||
| `' | ||
| ` id "'$2`"' | ||
| ` id "'$3`"' |
Contributor
There was a problem hiding this comment.
If you would like to make this field to be link_id, then you should align this value with the
default_hw_conf_id "'$2"'
in line 148.
They should be same value, no matter how you define them.
Collaborator
Author
There was a problem hiding this comment.
@xiulipan yes you are right. let me update it.
Previously it was set to be the dai index which works if there's only one type of BE DAI's. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Collaborator
Author
|
@xiulipan i've made the changes to match the id's now. |
Member
Collaborator
Author
|
@plbossart yes better to apply this along with or after #40 |
Contributor
|
LGTM, thanks. |
xiulipan
approved these changes
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was set to be the dai index which works if there's
only one type of BE DAI's.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com