PulseAudio: get preferredSampleRate#213
Merged
radarsat1 merged 2 commits intothestk:masterfrom Feb 24, 2020
Merged
Conversation
Contributor
|
I don't have an easy way to test this. You say a "proof of concept". Is it something that should be merged? |
Contributor
Author
|
i've been using the code in my studio link project for several months now and haven't had any user complaints, so i think it should be safe to merge it. its the only way to get the real samplerate so i can resample if necessary. |
Contributor
|
I'll test it |
Contributor
|
Yes, it seems to work reliably, and I don't see a cleaner way to do this, so I'll merge. Leaving the default 48000 for now too since I don't see any examples in other APIs where it can be left as 0 so I assume user code assumes it is non-zero. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a basic proof of concept to get the really preferred sample rate from pulseaudio async api.