Idea: removal of __MACOSX_CORE__ define

[dimitre]

This way we don't need to add this custom preprocessor definition to the project.

[keinstein]

Hi dimitre,

There is already code for cmake and Autoconf that automagically sets this macro if run on Mac OS. If not in this repository, then somewhere linked in the community.

CoreMIDI is not the only API that is supported on Mac OS X. It is a good practice that the developer can decide which one to compile in, at least for debugging purposes. Furthermore not every MACOSX like environment has access to CoreMIDI. For example GNUstep has no CoreMIDI implementation.

Last but not least: Did you try the following in your project?

#define __LINUX_ALSA__ 1 

If that compiles and runs well, you should also enable all the other architectures and APIs. It is very unlikely that your code still compiles.

Besides that, I agree with you that an automatic detection with opt-out is more elegant for most users. However, such a solution has to be maintained by developers to keep track with certain API changes.

So I assume this request would thow the baby out with the bathwater.

[dimitre]

Nice thanks for the explanation.
My (naive) thought was: if this define was always meant to be used on macOS it could be changed by other defines to detect platform.
And by searching this define in search engines we find most results are difficulties

Feel free to close this idea one as "won't happen" if it won't.