Skip to content

Conversation

@lukpueh
Copy link
Member

@lukpueh lukpueh commented Feb 16, 2022

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #1807

Description of the changes being introduced by the pull request:
Update README.md#Acknowledgements

  • Reword to acknowledge maintainer contributions as well
  • Remove names that are mentioned in maintainers document
    (Santiago Torres-Arias, Sebastien Awwad, Trishank Kuppusamy, Vladimir Diaz)
  • Remove duplicate Konstantin Andrianov
  • Add new significant contributors
    (Ivana Atanasova, Kairo de Araujo, Martin Vrachev)

Remove unmaintained AUTHORS.txt, which lists many individuals and organisations that are/were not affiliated with 'python-tuf', but other projects in the TUF ecosystem (Thandy, Notary, etc.) and thus is not suited for this repository.
-> theupdateframework.io#38

Caveats:

  • Significant contributors means top ~20 committers sorted by commit count (git shortlog -s).
  • The Acknowledgements section might miss significant contributors, if they contributed by other means than git commits in this repo.

PR also adds an automated reminder to update the Acknowledgements in the yearly maintainers doc review.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Lukas Puehringer added 2 commits February 16, 2022 11:01
Update README.md#Acknowledgements
- Reword to acknowledge maintainer contributions as well
- Remove names that are mentioned in maintainers document
- Remove duplicate Konstantin Andrianov
  Santiago Torres-Arias, Sebastien Awwad, Trishank Kuppusamy,
  Vladimir Diaz)
- Add new significant contributors
  (Ivana Atanasova, Kairo de Araujo, Martin Vrachev)

Remove unmaintained AUTHORS.txt, which lists many individuals and
organisations that are/were not affiliated with 'python-tuf', but
other projects in the TUF ecosystem (Thandy, Notary, etc.) and
thus is not suited for this repository.
-> theupdateframework.io#38

Caveats:
- Significant contributors means  top ~20 committers sorted by
  commit count (`git shortlog -s`).
- The Acknowledgements section might miss significant contributors,
  if they contributed by other means than git commits in this repo.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Add optional task to  maintainer permission review reminder
checklist that suggests to also update the list of significant
contributors in README.md#acknowledgements.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1852255522

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.348%

Totals Coverage Status
Change from base Build 1847342708: 0.0%
Covered Lines: 1122
Relevant Lines: 1138

💛 - Coveralls

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@coveralls
Copy link

coveralls commented Jan 1, 2025

Pull Request Test Coverage Report for Build 1852255522

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.574%

Totals Coverage Status
Change from base Build 1847342708: 0.2%
Covered Lines: 1095
Relevant Lines: 1107

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Remove AUTHORS.txt (or make it up-to-date)

3 participants