User timezone should also be evaluated from user details #18#19
User timezone should also be evaluated from user details #18#19collinkrawll merged 3 commits intothirdset:masterfrom PruvoNet:master
Conversation
|
@collinkrawll can you please review? |
|
@regevbr This looks great! I should have time to test and merge it early this week. Thanks! |
|
@collinkrawll sure thing! Maybe a better explanation about the "user timezone" in the README is in order as well? I thought that what I changed here was obvious but after I saw the emails were sent in wrong times, I investigated your code and realized my assumption was wrong. |
|
@regevbr Feel free to add an update to the README.md to this PR or a separate PR as well if you have an idea for how to improve it. Thanks! |
|
@collinkrawll I updated the readme and added a unit test and fixed the tests to run with mautic 2.15.1. My change is a breaking change, so please consider releasing a major version for it. Also, since mautic 2.15.1 is the latest stable version, can you please test against it and update the readme for the supported version? I tested and used this fix in 2.15.1 already at it works well for me. |
|
@regevbr I just merged this and released your changes in v2.0.0 of the plugin. A couple of notes:
Thanks again. |
|
@collinkrawll thanks for the swift handling :-) Yes I already looked at your code and makes sense - good thing you noticed! As to the docker - I already have a pending PR there to upgrade it to 2.15.1 - mautic/docker-mautic#117 I will mention you there so you can get notified when they release it so you can test 2.15.1 as well if you desire. |
|
@collinkrawll the new docker image is out, can you test it on 2.15.1? |
|
@regevbr done. Thanks! |
User timezone should also be evaluated from user details #18