Skip to content

Revert "redis tls support (#95)"#96

Merged
nischitpra merged 1 commit intomainfrom
np/revert_tls
Feb 11, 2026
Merged

Revert "redis tls support (#95)"#96
nischitpra merged 1 commit intomainfrom
np/revert_tls

Conversation

@nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Feb 11, 2026

This reverts commit d729f5f.

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed Rustls TLS support from Redis dependency configuration
    • Simplified Redis setup by eliminating TLS-related features
    • Updated documentation to remove TLS configuration examples

@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This PR removes TLS/Rustls support and Redis Cluster hash-tagging from the project. Rustls dependency and crypto provider initialization are eliminated, all TLS-related features removed from Redis configuration, and Redis Cluster hash-tag helpers are replaced with direct queue name references throughout the codebase and tests.

Changes

Cohort / File(s) Summary
Rustls & TLS Dependency Removal
Cargo.toml, server/Cargo.toml, twmq/Cargo.toml, server/src/main.rs
Removed Rustls dependency declaration and TLS-related Redis features. Eliminated the Rustls crypto provider initialization block in server startup.
Redis Hash-tag Helper Removal
twmq/src/lib.rs, twmq/src/multilane.rs
Removed private Redis hash-tag helpers (redis_hash_tag()) and replaced all usages with direct queue name/ID references in key construction and Lua script arguments. Changes how data structure keys (pending, delayed, active, results, dedupe) are addressed in Redis.
Test Key Pattern Updates
twmq/tests/basic.rs, twmq/tests/basic_hook.rs, twmq/tests/delay.rs, twmq/tests/idempotency_modes.rs, twmq/tests/lease_expiry.rs, twmq/tests/multilane_batch_pop.rs, twmq/tests/nack.rs, twmq/tests/prune_race_condition.rs, twmq/tests/prune_race_random_ids.rs
Updated Redis key cleanup patterns from hash-tagged format (twmq:{{queue_name}}:*) to plain format (twmq:{queue_name}:*), altering which keys are matched for test cleanup.
Documentation Updates
README.md, server/DOCKER.md
Removed commented TLS guidance, rediss:// Redis URL examples, and TLS-specific configuration references from documentation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • redis tls support #95 — Directly reverses prior changes that introduced Rustls and Redis Cluster hash-tagging support; this PR removes those same additions.

Suggested reviewers

  • 0xFirekeeper
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch np/revert_tls

Comment @coderabbitai help to get the list of available commands and usage tips.

@nischitpra nischitpra merged commit e570bc8 into main Feb 11, 2026
3 of 5 checks passed
@nischitpra nischitpra deleted the np/revert_tls branch February 11, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant