feat: updates card design for kits and homepage#1291
Conversation
✅ Deploy Preview for starter-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…jsons, and changes homepage avail kit styles
jdwilkin4
left a comment
There was a problem hiding this comment.
Looks good.
Left a couple of small comments 👍
lindakatcodes
left a comment
There was a problem hiding this comment.
Code in general seems good to me! A few comments on showcases that aren't actually ready for display, but also a few things as I'm running it locally:
Homepage:
- Can we adjust the size of the cards or at least the icon spacing? Being the 3x4 like this, there's too much space in between each icon side by side as opposed to between the rows. It looks funky compared to the design (which I know does 4 across instead of the 3 we decided on). Feels like the spacing should match better somehow.
Individual kit page:
- In the design, the navigation is showing the actual showcase name. However on our site, it's showing "Kits". Can we fix that?
- I'm pretty sure we're meant to show both the repo and the live app here? Unless there's a conversation I've missed somewhere. We should have the info to show both links like the design does.
…d to kitname, swap back showcase to false for nuxt and remix
lindakatcodes
left a comment
There was a problem hiding this comment.
Looking wonderful! Nice job! 🥇
…d, no lf align, mb f-width, and mb hd styles in ctas
|
I have pushed a commit that handles the requested feedback from Dustin except for the duplicate logos. |
jdwilkin4
left a comment
There was a problem hiding this comment.
Looks good.
Left a couple of small comments 👍
|
Kudos, SonarCloud Quality Gate passed!
|
jdwilkin4
left a comment
There was a problem hiding this comment.
Left one small comment about an unused line of commented out code but otherwise I think is good to go
Co-authored-by: Jessica Wilkins <67210629+jdwilkin4@users.noreply.github.com>

















Type of change
Summary of change
Screenshots
Homepage


Individual kit


Checklist