Skip to content

feat: updates card design for kits and homepage#1291

Merged
lindakatcodes merged 30 commits intomainfrom
feat/1284-update-card-design-kits
Jul 6, 2023
Merged

feat: updates card design for kits and homepage#1291
lindakatcodes merged 30 commits intomainfrom
feat/1284-update-card-design-kits

Conversation

@WillHutt
Copy link
Contributor

@WillHutt WillHutt commented Jun 23, 2023

Type of change

  • Feature
  • Documentation change
  • Bug fix

Summary of change

  • This updates the homepage and kit pages to reflect the option 1 selection in the Figma designs found in the Slack PTA channel
    • Updates the homepage to include more icons with a layout of 4x3 and adds a title for the kit
    • Adds a showcase section to individual kits with a View Showcase option that navigates to the section on the page
    • Adds updated keywords and icons from [pods] - Update keywords and icons for kits #1283
    • Updates packages to reflect which kits have showcases
    • Resolves 2 failing checks

Screenshots

Homepage
deploy-preview-1291--starter-dev netlify app_ (1)
deploy-preview-1291--starter-dev netlify app_

Individual kit
deploy-preview-1291--starter-dev netlify app_kits_next-react-query-tailwind_ (1)
deploy-preview-1291--starter-dev netlify app_kits_next-react-query-tailwind_

Checklist

@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for starter-dev ready!

Name Link
🔨 Latest commit a6cedb5
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/64a6e142646dde0008ee6c6a
😎 Deploy Preview https://deploy-preview-1291--starter-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WillHutt WillHutt added the WIP Work in Progress label Jun 23, 2023
Copy link
Contributor

@vyktoremario vyktoremario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question

@WillHutt WillHutt changed the title feat: updates card design for kits and homepage [WIP] feat: updates card design for kits and homepage [WIP] Jun 26, 2023
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Left a couple of small comments 👍

@WillHutt WillHutt changed the title [WIP] feat: updates card design for kits and homepage [WIP] feat: updates card design for kits and homepage Jun 27, 2023
@WillHutt WillHutt removed the WIP Work in Progress label Jun 27, 2023
Copy link
Contributor

@lindakatcodes lindakatcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code in general seems good to me! A few comments on showcases that aren't actually ready for display, but also a few things as I'm running it locally:

Homepage:

  • Can we adjust the size of the cards or at least the icon spacing? Being the 3x4 like this, there's too much space in between each icon side by side as opposed to between the rows. It looks funky compared to the design (which I know does 4 across instead of the 3 we decided on). Feels like the spacing should match better somehow.
Screen Shot 2023-06-27 at 9 55 01 AM

Individual kit page:

  • In the design, the navigation is showing the actual showcase name. However on our site, it's showing "Kits". Can we fix that?
Screen Shot 2023-06-27 at 9 59 03 AM Screen Shot 2023-06-27 at 9 59 15 AM - I'm pretty sure we're meant to show both the repo and the live app here? Unless there's a conversation I've missed somewhere. We should have the info to show both links like the design does. Screen Shot 2023-06-27 at 10 02 24 AM Screen Shot 2023-06-27 at 10 01 24 AM

@WillHutt WillHutt added the WIP Work in Progress label Jun 27, 2023
@WillHutt WillHutt requested a review from lindakatcodes June 28, 2023 15:26
lindakatcodes
lindakatcodes previously approved these changes Jun 28, 2023
Copy link
Contributor

@lindakatcodes lindakatcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking wonderful! Nice job! 🥇

jdwilkin4
jdwilkin4 previously approved these changes Jun 28, 2023
lindakatcodes
lindakatcodes previously approved these changes Jun 28, 2023
@WillHutt
Copy link
Contributor Author

WillHutt commented Jun 29, 2023

Feedback to address from Dustin:

  • Columns/rows
    [ ] [ ] [ ] [ ]
    [ ] [ ] [ ] [ ]
    [ ] [ ] [ ] [ ]

  • Container squares feel too skinny add more lr padding
    image

  • Remove duplicate logos
    image

  • Light mode title is too light
    image

  • Make plural
    image

  • Doesn't look good in light mode and feels too cramped in dark mode. Add more padding
    image
    image

  • Skinny container feels really bad because it doesn't left align with the rest of the page
    image

  • Mobile, this should probably take the full width
    image

  • Header styles on mobile are off especially with CTAs
    image

…d, no lf align, mb f-width, and mb hd styles in ctas
@WillHutt
Copy link
Contributor Author

WillHutt commented Jun 30, 2023

I have pushed a commit that handles the requested feedback from Dustin except for the duplicate logos.

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Left a couple of small comments 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jdwilkin4
jdwilkin4 previously approved these changes Jul 6, 2023
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small comment about an unused line of commented out code but otherwise I think is good to go

Co-authored-by: Jessica Wilkins  <67210629+jdwilkin4@users.noreply.github.com>
@lindakatcodes lindakatcodes merged commit 55a9259 into main Jul 6, 2023
@lindakatcodes lindakatcodes deleted the feat/1284-update-card-design-kits branch July 6, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pods] - Update card designs for kits

4 participants