Fix Several Compiler Warnings, and Optimize CI scripts #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biergaizi
force-pushed
the
fix-warnings
branch
2 times, most recently
from
87b29ad to
ccdbedd
Compare
biergaizi
changed the title
Contributor
Author
|
Merge ready. |
ParameterObjects.cpp:27:9: warning: unused variable 'dHelp' [-Wunused-variable]
27 | double dHelp;
| ^~~~~
1 warning generated.
Signed-off-by: Yifeng Li <tomli@tomli.me>
If "Wimplicit-fallthrough" (part of "-Wextra") is enabled, GCC
requires fallthrough switch/case to explicitly marked with a
compiler intrinsic or a text comment. Mark Cylindrical coordinate
preprocessing with a fallthrough comment.
/home/fdtd/CSXCAD/src/CSPrimitives.cpp: In function ‘bool CoordInRange(const double*, const double*, const double*, CoordinateSystem)’:
/home/fdtd/CSXCAD/src/CSPrimitives.cpp:60:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
60 | if (p[1]<std::min(start[1],stop[1]))
| ^~
/home/fdtd/CSXCAD/src/CSPrimitives.cpp:66:9: note: here
66 | case CARTESIAN:
| ^~~~
Signed-off-by: Yifeng Li <tomli@tomli.me>
The header `AABB_traits.h` is now deprecated in CGAL v6.
More to `AABB_traits_6.h` for CGAL v6+.
In file included from /usr/include/CGAL/AABB_traits.h:19,
from /home/fdtd/CSXCAD/src/CSPrimPolyhedron_p.h:10,
from /home/fdtd/CSXCAD/src/CSPrimPolyhedron.cpp:25:
/usr/include/CGAL/Installation/internal/deprecation_warning.h:80:6: warning: #warning "A deprecated header has been included." [-Wcpp]
80 | # warning "A deprecated header has been included."
| ^~~~~~~
Signed-off-by: Yifeng Li <tomli@tomli.me>
Use GitHub Actions "actions/checkout" to fetch source code on FreeBSD instead of manually launching git. Also, enable compiler warnings via CXXFLAGS on all platforms. Signed-off-by: Yifeng Li <tomli@tomli.me>
biergaizi
force-pushed
the
fix-warnings
branch
from
ccdbedd to
aab4e07
Compare
Contributor
Author
|
Hello, can this Pull Request be merged now? |
Owner
|
okay missed these... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
A constant flood of warnings is harmful, even if the warnings are safe to ignore, because they would mask useful warnings in the future (a real bug has indeed been found, a separate discussion is needed, see #75). This Pull Request fix several compiler warnings.
src/ParameterObjects.cpp: remove unused "dHelp"
src/CSPrimitives.cpp: add a fallthrough comment in CoordInRange
If
Wimplicit-fallthrough(part of-Wextra) is enabled, GCC requires fallthrough switch/case to explicitly marked with a compiler intrinsic or a text comment. Mark Cylindrical coordinate preprocessing with a fallthrough comment.src/CSPrimPolyhedron_p.h: fix CGAL 6 deprecation
The header
AABB_traits.his now deprecated in CGAL v6. More toAABB_traits_6.hfor CGAL v6+.CI: Enable compiler warnings, use actions/checkout for FreeBSD
Use GitHub Actions
actions/checkoutto fetch source code on FreeBSD instead of manually launching git. Also, enable compiler warnings viaCXXFLAGSon all platforms.