add support to pass options directly into es6ify function#24
Closed
guzart wants to merge 1 commit intothlorenz:masterfrom
guzart:feature/add-options-api
Closed
add support to pass options directly into es6ify function#24guzart wants to merge 1 commit intothlorenz:masterfrom guzart:feature/add-options-api
guzart wants to merge 1 commit intothlorenz:masterfrom
guzart:feature/add-options-api
Conversation
Owner
|
Additionally to the inline code comments, please consider the API I suggested in the issue: #23 (comment) This PR doesn't implement it that way, but somehow configure still takes a regex instead of an options object like I suggested. |
Owner
|
Closing this as the discussion moved to #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference #23