Skip to content

Fix Race Condition in Form Handlers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thmarx merged 1 commit into from
Nov 11, 2025
Merged

Fix Race Condition in Form Handlers #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions src/main/java/com/condation/cms/modules/forms/handler/AjaxSubmitFormHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ public boolean handle(Request request, Response response, Callback callback) thr

FormsHandling formHandling = new FormsHandling(hookSystem);

final AtomicReference<FormResponse> formResponse = new AtomicReference<>();
try {
if (MimeTypes.Type.FORM_ENCODED.is(contentType)) {
FormFields.onFields(request, StandardCharsets.UTF_8, new Promise.Invocable<Fields>() {
@Override
public void succeeded(Fields fields) {
FormResponse formResponse;
try {
final String formName = fields.get("form").getValue();
var form = FormsLifecycleExtension.FORMSCONFIG.findForm(formName).get();
Expand All @@ -78,16 +78,21 @@ public void succeeded(Fields fields) {
}
return field;
});
formResponse.set(new FormResponse(false));
formResponse = new FormResponse(false);
response.setStatus(HttpStatus.OK_200);
} catch (FormHandlingException fhe) {
log.error(null, fhe);
formResponse.set(new FormResponse(true));
formResponse = new FormResponse(true);
response.setStatus(HttpStatus.BAD_REQUEST_400);
}
Content.Sink.write(response, true, GSON.toJson(formResponse), callback);
}

@Override
public void failed(Throwable x) {
formResponse.set(new FormResponse(true));
var formResponse = new FormResponse(true);
response.setStatus(HttpStatus.BAD_REQUEST_400);
Content.Sink.write(response, true, GSON.toJson(formResponse), callback);
}
});
} else if (contentType.startsWith(MimeTypes.Type.MULTIPART_FORM_DATA.asString())) {
Expand All @@ -98,11 +103,14 @@ public void failed(Throwable x) {
parser.parse(request, new Promise.Invocable<MultiPartFormData.Parts>() {
@Override
public void failed(Throwable x) {
formResponse.set(new FormResponse(true));
var formResponse = new FormResponse(true);
response.setStatus(HttpStatus.BAD_REQUEST_400);
Content.Sink.write(response, true, GSON.toJson(formResponse), callback);
}

@Override
public void succeeded(MultiPartFormData.Parts parts) {
FormResponse formResponse;
try {

String formName = parts.getFirst("form").getContentAsString(StandardCharsets.UTF_8);
Expand All @@ -114,26 +122,28 @@ public void succeeded(MultiPartFormData.Parts parts) {
return field;
});

formResponse.set(new FormResponse(false));

formResponse = new FormResponse(false);
response.setStatus(HttpStatus.OK_200);
} catch (FormHandlingException fhe) {
log.error(null, fhe);
formResponse.set(new FormResponse(true));
formResponse = new FormResponse(true);
response.setStatus(HttpStatus.BAD_REQUEST_400);
}
Content.Sink.write(response, true, GSON.toJson(formResponse), callback);
}

});
} else {
var formResponse = new FormResponse(true);
response.setStatus(HttpStatus.BAD_REQUEST_400);
Content.Sink.write(response, true, GSON.toJson(formResponse), callback);
}
} catch (Exception e) {
log.error("error processing form", e);
}

if (formResponse.get().error()) {
var formResponse = new FormResponse(true);
response.setStatus(HttpStatus.BAD_REQUEST_400);
} else {
response.setStatus(HttpStatus.OK_200);
Content.Sink.write(response, true, GSON.toJson(formResponse), callback);
}
Content.Sink.write(response, true, GSON.toJson(formResponse.get()), callback);

return true;
}
Expand Down
20 changes: 13 additions & 7 deletions src/main/java/com/condation/cms/modules/forms/handler/SubmitFormHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public boolean handle(Request request, Response response, Callback callback) thr
public void failed(Throwable x) {
response.getHeaders().add("Location", FormsLifecycleExtension.FORMSCONFIG.getRedirects().getError());
response.setStatus(HttpStatus.MOVED_TEMPORARILY_302);
callback.succeeded();
}

@Override
Expand All @@ -101,10 +102,11 @@ public void succeeded(Fields fields) {
response.getHeaders().add("Location", FormsLifecycleExtension.FORMSCONFIG.getRedirects().getError());
response.setStatus(HttpStatus.MOVED_TEMPORARILY_302);
}
} finally {
callback.succeeded();
}
}
});
return true;
} else if (contentType.startsWith(MimeTypes.Type.MULTIPART_FORM_DATA.asString())) {
String boundary = MultiPart.extractBoundary(contentType);
MultiPartFormData.Parser parser = new MultiPartFormData.Parser(boundary);
Expand All @@ -114,7 +116,7 @@ public void succeeded(Fields fields) {
public void failed(Throwable x) {
response.getHeaders().add("Location", FormsLifecycleExtension.FORMSCONFIG.getRedirects().getError());
response.setStatus(HttpStatus.MOVED_TEMPORARILY_302);

callback.succeeded();
}

@Override
Expand Down Expand Up @@ -143,19 +145,23 @@ public void succeeded(MultiPartFormData.Parts parts) {
response.getHeaders().add("Location", FormsLifecycleExtension.FORMSCONFIG.getRedirects().getError());
response.setStatus(HttpStatus.MOVED_TEMPORARILY_302);
}
} finally {
callback.succeeded();
}
}

});
return true;
} else {
response.getHeaders().add("Location", FormsLifecycleExtension.FORMSCONFIG.getRedirects().getError());
response.setStatus(HttpStatus.MOVED_TEMPORARILY_302);
callback.succeeded();
}
} catch (Exception e) {
log.error("error processing form", e);
response.getHeaders().add("Location", FormsLifecycleExtension.FORMSCONFIG.getRedirects().getError());
response.setStatus(HttpStatus.MOVED_TEMPORARILY_302);
callback.succeeded();
}

response.getHeaders().add("Location", FormsLifecycleExtension.FORMSCONFIG.getRedirects().getError());
response.setStatus(HttpStatus.MOVED_TEMPORARILY_302);
callback.succeeded();
return true;
}
}