Automatic dep management#2
Open
dannysauer wants to merge 3 commits into
Open
Conversation
Set package versions in an external requirements.txt file This facilitates more easily adding/removing modules without editing the Dockerfile itself Possibly more importantly, this also facilitates having dependabot tracking on the modules so it can make PRs to update the repo as new module versions are published to pypi
Track Python, Docker, and actions
Author
|
I left the gunicorn version out of the requirements.txt for this PR, since it's not managed in this fork or upstream currently. In my fork, I have the version on that as well so any dependency update will trigger a container rebuild. There's nothing to necessarily indicate that's desired here, so I erred on the side of caution. :) I'm a fan of removing gunicorn from the requirements.txt altogether and using this if all the deps should be in there, I guess. docker build --target build -t pulp-core-build .
docker run --rm pulp-core-build /opt/pulp/bin/pip freeze --all -l -r /opt/pulp/pulp-requirements.txt > requirements.txt
docker rmi pulp-core-build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the python modules out to a separate requirements.txt so dependabot can more happily update modules when they're released, and to reduce direct Dockerfile editing. Maybe the requirements.txt should go in /tmp, but I thought it might be useful for diagnostics later. 🤷
I also had to install compat-openssl10 for the containers to behave. I didn't dig in to what requires the old library name. More shrugging. :D