BuildSystem v3 #201
Merged
BuildSystem v3 #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmny
removed
the
stale
thomasmny
force-pushed
the
dev/v3
branch
2 times, most recently
from
72e9091 to
a0d37d0
Compare
This was
linked to
issues
Jul 7, 2025
Closed
Closed
There was a problem hiding this comment.
Pull Request Overview
BuildSystem v3 refactors core components to the new plugin API, introduces null-safety annotations, and replaces the old inventory/listener framework with the InventoryHandler/InventoryManager system.
- Switched from
BuildSystemtoBuildSystemPluginthroughout - Added
@NullMarkedannotations and updated null checks - Replaced legacy listener-based GUIs with
InventoryHandlerimplementations
Reviewed Changes
Copilot reviewed 206 out of 307 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NoClipManager.java | Updated package, swapped plugin type, added null-safety |
| DesignInventory.java | Converted to InventoryHandler, removed direct Bukkit calls |
| CustomBlocksManager.java | Simplified rotateBlock using pattern matching; added null checks |
| CustomBlock.java | Moved enum to new package, removed obsolete version field |
| BlocksInventory.java | New inventory class using InventoryHandler and InventoryManager |
Comments suppressed due to low confidence (4)
buildsystem-core/src/main/java/de/eintosti/buildsystem/player/customblocks/CustomBlocksManager.java:193
- The key string
"invisible-itemframe"is duplicated in multiple places; consider defining it as a constant to avoid typos and ease future changes.
if (itemMeta == null || !itemMeta.getPersistentDataContainer().has(this.invisibleFrameKey, PersistentDataType.BYTE)) {
buildsystem-core/src/main/java/de/eintosti/buildsystem/listener/PlayerTeleportListener.java:50
- [nitpick] Using
getWorlds().getFirst()to detect the main world relies on list ordering; consider exposing a named or configured main world identifier for clarity.
if (event.getCause() != PlayerTeleportEvent.TeleportCause.UNKNOWN) {
buildsystem-core/src/main/java/de/eintosti/buildsystem/player/settings/NoClipManager.java:22
- The
Settingsimport is never used in this class; consider removing it to reduce clutter.
import de.eintosti.buildsystem.api.player.settings.Settings;
buildsystem-core/src/main/java/de/eintosti/buildsystem/player/customblocks/CustomBlock.java:61
- [nitpick] The legacy constructor overloads and commented-out
versionhandling have been removed; ensure any residual dead code is cleaned up.
}
Comment on lines
43
to
52
| BuildWorld buildWorld = worldStorage.getBuildWorld(from.getName()); | ||
| if (buildWorld != null) { | ||
| buildWorld.resetUnloadTask(); | ||
| buildWorld.getUnloader().resetUnloadTask(); | ||
| } | ||
| } | ||
|
|
||
| @EventHandler | ||
| public void onPlayerQuit(PlayerQuitEvent event) { | ||
| World from = event.getPlayer().getWorld(); | ||
| BuildWorld buildWorld = worldManager.getBuildWorld(from.getName()); | ||
| BuildWorld buildWorld = worldStorage.getBuildWorld(from.getName()); |
There was a problem hiding this comment.
[nitpick] Identical resetUnloadTask() calls appear in both event handlers; consider extracting to a single private method to avoid duplication.
Closed
thomasmny
force-pushed
the
dev/v3
branch
2 times, most recently
from
39057f6 to
2403d90
Compare
- Don't allow folders with subfolders to be deleted - Also `BuildWorld` -> `Folder` assignment in world object instead of map in `FolderStorageImpl`
…ethods, and refactor related code for improved clarity and error handling
Also check whether default game rules set in config exist and are of correct type
…pdateAndReopenInventory()`
…t folders and improving documentation
…bility and enforce unmodifiable collections where applicable
- `/worlds public`: Open public worlds - `/worlds archive`: Open archived worlds - `/worlds private`: Open private worlds Closes #243
…erences for improved clarity
Also add @contract annotations to improve nullability handling and enhance code clarity
…new methods and improve item creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in v3
Bug fixes
Other changes