Adding the option to disable the adventure game mode on archived worlds #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good so far.
|
Contributor
Author
|
That's actually a good suggestion. Will implement it today afternoon |
Contributor
Author
|
Implemented it now, may you check again, please? |
thomasmny
requested changes
Sep 19, 2024
Owner
thomasmny
left a comment
thomasmny
left a comment
There was a problem hiding this comment.
All in all very good, just a few nitpicks
buildsystem-core/src/main/java/de/eintosti/buildsystem/config/ConfigValues.java
Outdated
Show resolved
Hide resolved
buildsystem-core/src/main/java/de/eintosti/buildsystem/config/ConfigValues.java
Outdated
Show resolved
Hide resolved
|
|
||
| private void setSpectatorMode(Player player) { | ||
| player.setGameMode(GameMode.ADVENTURE); | ||
| // Checking if the game mode should be set to adventure mode on archive worlds |
Owner
There was a problem hiding this comment.
You can remove the comment, code should be self-explanatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #286
Please note: we will close your Pull Request without comment if you do not check the box above and provide ALL
requested information.