Skip to content

Conversation

@thomasmny
Copy link
Owner

If the server is behind a proxy & the player is offline which a UUID fetch is made, a different one will be returned than if the player were to be online.

Thus, the UUIDFetcher should behave differently for offline servers and online/proxy servers

If the server is behind a proxy & the player is offline which a UUID fetch is made, a different one will be returned than if the player were to be online.

Thus, the UUIDFetcher should behave differently for offline servers and online/proxy servers
@thomasmny
Copy link
Owner Author

thomasmny commented Feb 2, 2025

@Lumine1909 Can you try this version and see if it works for you? It seems that #300 caused some issues with servers behind Velocity if:

  1. PlayerA is offline
  2. PlayerB adds PlayerA to the builder of a world
  3. PlayerA joins the server

@Lumine1909
Copy link
Contributor

@Lumine1909 Can you try this version and see if it works for you? It seems that #300 caused some issues with servers behind Velocity if:

  1. PlayerA is offline
  2. PlayerB adds PlayerA to the builder of a world
  3. PlayerA joins the server

Has player A ever joined to the server?

@DeadlyCinder
Copy link

So what happened to me was:

I tried to remove a player as builder from my world. Although the chat message said it was done the GUI and the config file didnt change. Then i tried adding a player as builder, but the plugin pulled the wrong uuid because the player was offline. When he was online it worked.

After getting this Snapshot Version the issue was fixed

@Lumine1909
Copy link
Contributor

Lumine1909 commented Feb 3, 2025

This will still causing some issues when working with Offline proxy mode
Please check #335

* Modify ServerModeChecker and support offline-proxy mode

* Use bukkit logic as fallback
@thomasmny thomasmny merged commit b5c8b05 into master Apr 26, 2025
2 checks passed
@thomasmny thomasmny deleted the fix/improve-uuid-fetcher branch April 26, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants