-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
It seems (quite surprisingly) that there is some confusion between the checkResFile/analysisSoftwareVersion functions and methods signatures:
* checking whether package ‘MSGFplus’ can be installed ... WARNING
Found the following significant warnings:
Warning: For function ‘checkResFile’, signature ‘msgfRes’: argument in method definition changed from (object) to (file)
Warning: For function ‘analysisSoftwareVersion’, signature ‘msgfRes’: argument in method definition changed from (object) to (file)
Easy to fix by change the function name or (I assume but not tested), renaming the function argument from file to object. Unless I'm missing anything here, happy to send another pull request.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels