Skip to content

Argument in method definition warnings #2

@lgatto

Description

@lgatto

It seems (quite surprisingly) that there is some confusion between the checkResFile/analysisSoftwareVersion functions and methods signatures:

* checking whether package ‘MSGFplus’ can be installed ... WARNING
Found the following significant warnings:
  Warning: For function ‘checkResFile’, signature ‘msgfRes’: argument in method definition changed from (object) to (file)
  Warning: For function ‘analysisSoftwareVersion’, signature ‘msgfRes’: argument in method definition changed from (object) to (file)

Easy to fix by change the function name or (I assume but not tested), renaming the function argument from file to object. Unless I'm missing anything here, happy to send another pull request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions