Replies: 23 comments 85 replies
-
|
Maybe I overlooked something (I made my first TUnit steps today), but I miss a feature that you can generate the data on the specified types. Currently I am using xUnit in conjunction with AutoFixture. Basically you have to implement a Create method with all defined types as parameters. The attribute subclassing is not the perfect solution, but it does what is needed. In the end I want to write a test like this: From your documentation I can only find the MethodDataSource, but there is no way to get the information about the arguments of the test. |
Beta Was this translation helpful? Give feedback.
-
|
@thomhurst I had a look and I still think it should be feasible. And out of interest: do you plan to create an analyzer for the attribute? Because right now if there is a mismatch between the parameters of the test method and the type arguments provided to the attribute this will result in a runtime error. |
Beta Was this translation helpful? Give feedback.
-
|
I'll pass in a parameter info array for you then! Hopefully I can do that tonight. And yeah I do intend to write some analyzers for it. Just haven't gotten round to it yet |
Beta Was this translation helpful? Give feedback.
-
|
@dev-in-disguise this is done now! You can be passed either a property info (for property injection) or a parameter info array. Let me know if it lets you achieve what you need! |
Beta Was this translation helpful? Give feedback.
-
|
@thomhurst I started today with the implementation. So far it looks great (and also awesome btw. that you could already add the analyzer as well!). Just one thing: when I add more than one attribute on a test method I encounter an (at least for me) unexpected behaviour. I would have expected one test and one data generation per attribute. I checked that against XUnits What is your reasoning behind doing it this way? Or maybe is this behaviour unintended? |
Beta Was this translation helpful? Give feedback.
-
|
Ah yes. I think I know why! It'll be a bug. If you want to raise it I'll try and take a look later |
Beta Was this translation helpful? Give feedback.
-
|
Hi,
Do I have the ability to repeat the test in growing intervals?
For instance, if the test fails because of a loss of connection, can I
repeat it after 10 sec min, and if still fails, then after 25 seconds,
then after 1 min?
…On Thu, Sep 26, 2024 at 7:11 PM Tom Longhurst ***@***.***> wrote:
Is there a feature that other frameworks provide that TUnit doesn't?
Is there a feature that they don't support but you wish they did?
I'm open to suggestions on anything that'd help make TUnit meet your
testing needs.
—
Reply to this email directly, view it on GitHub
<#646>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENYVK4NKS4QI3QKYPCOLZ3ZYQ55RAVCNFSM6AAAAABO5PCE6WVHI2DSMVQWIX3LMV43ERDJONRXK43TNFXW4OZXGI2DAMZSGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Hey @MiroKov ! Yeah this can easily be done. You can create your own retry attributes that simply inherit from It returns a task so you can wait asynchronously in there. E.g. public class ExponentialRetryAttribute(int times) : RetryAttribute(times)
{
public override async Task<bool> ShouldRetry(TestContext context, Exception exception, int currentRetryCount)
{
await Task.Delay(TimeSpan.FromSeconds(currentRetryCount));
return true;
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Vow! Do you have any notion of when will this come out of prerelease?Can’t wait to start using this.On 4. Oct 2024, at 00:49, Tom Longhurst ***@***.***> wrote:
Hey @MiroKov ! Yeah this can easily be done.
You can create your own retry attributes that simply inherit from RetryAttribute. Then you can plug your own logic into the ShouldRetry method.
It returns a task so you can wait asynchronously in there.
E.g.
public class ExponentialRetryAttribute(int times) : RetryAttribute(times)
{
public override async Task<bool> ShouldRetry(TestContext context, Exception exception, int currentRetryCount)
{
await Task.Delay(TimeSpan.FromSeconds(currentRetryCount));
return true;
}
}
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Hopefully in the next couple of months. I'm just collecting user feedback before I mark the API as stable |
Beta Was this translation helpful? Give feedback.
-
|
👍On 4. Oct 2024, at 07:29, Tom Longhurst ***@***.***> wrote:
Hopefully in the next couple of months.
I'm just collecting user feedback before I mark the API as stable
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Is there some way to combine multiple In my case I want to run all my tests with different with different fixtures, so I have a base class with a Here's a quick example: [TestFixtureSource(typeof(DatabaseFixtureSource))]
public abstract class WebserverTests
{
protected WebserverTests(WebserverFixture fixture)
{
Fixture = fixture;
}
protected WebserverFixture Fixture { get; }
}
public sealed class ExampleTests(WebserverFixture fixture) : WebserverTests(fixture)
{
[Test]
public void Test() => Assert.Pass();
}
[TestFixtureSource(typeof(OtherFixtureSource))]
public sealed class CombinedTests(WebserverFixture fixture, OtherFixture other) : WebserverTests(fixture)
{
[Test]
public void Test() => Assert.Pass();
}I'm not really sure what would be the best way to port this to One thing I couldn't figure out in |
Beta Was this translation helpful? Give feedback.
-
|
Does WebserverFixture have a parameterless constructor? If so you can use
and in |
Beta Was this translation helpful? Give feedback.
-
I don't quite understand. Can you give a code example of what you're trying to achieve? |
Beta Was this translation helpful? Give feedback.
-
I want to run all API integration tests against different databases, in my case different versions of PostgreSQL and Sqlite. The issue is that Dapper requires static configuration, see sqlite and PostgreSQL. Right now I have a hacky workaround for it - including the same source files in separate projects for each database. |
Beta Was this translation helpful? Give feedback.
-
Right now it does have parameters, see example, but in this case I guess I can make subclases if needed. |
Beta Was this translation helpful? Give feedback.
-
I got it working using |
Beta Was this translation helpful? Give feedback.
-
|
A feature that would be really useful would be what xUnit is calling two-phase parametrised tests. (Although it has yet to be implemented) The idea is that a data source (such as from a DataSourceGeneratorAttribute) can interrupt the enumeration of generated test cases. This is very useful for property-based testing libraries that generate multiple random test cases for a single parameterised test method. The original xUnit issue is here xunit/xunit#1719 but to paraphrase, the process is:
In the shrinking phase, the property-based testing library uses various heuristics to simplify the (randomly generated) test case to a single human-readable repro. The problem with xUnit and other existing libraries is that they see both these generated test cases and the test cases generated by the shrinking algorithm as a single test, not a parameterised one with multiple inputs, making the test runner results unhelpful. I don't think TUnit supports this yet (although if I'm wrong, I'd happily be corrected), but I'd have thought it'd be much easier to implement while the framework is still young. |
Beta Was this translation helpful? Give feedback.
-
|
@Vespion been looking into this. What do you think of this? In the example it's all abstracted away behind a custom attribute of |
Beta Was this translation helpful? Give feedback.
-
|
From what I can tell, it solves the problem perfectly. I love how extensible TUnit is without getting in the way. Without playing around with it, I can't be entirely sure it'll work, but I don't see any obvious issues. Unless that'd get in the way? |
Beta Was this translation helpful? Give feedback.
-
|
If you have time, go for it! I'm off to bed now 😴 |
Beta Was this translation helpful? Give feedback.
-
|
Oof, yeah looking at it I really should be too XD |
Beta Was this translation helpful? Give feedback.
-
|
@Vespion that FsCheck library is way beyond my understanding. I'm struggling to understand it even with the documentation haha. Seems you need to construct a So yeah I'll leave it up to you to experiment! |
Beta Was this translation helpful? Give feedback.
-
|
It took a while for me to check back to this thread. As for the AutoFixture part, I dont think that the current implementation would fit my developers. There is no point in type checking. It just makes writing tests painful. The whole idea of writing tests with AutoFixture is that you just write parameters in your tests and they will be created behind the scenes. When I change the type of the parameter to another, then I need another parameter. This would force to change every parameter twice with no benefit. Also if you write a migration from xUnit, where you currently just subclass the AutoDataAttribute to e.g. AutoNSubstiuteDataAttribute. You would be forced to subclass every generic attribute. Writing a lot of useless code. This is done just to override the Fixture factory, so there are other ways to solve this. A matter of how much different TUnit should feel. It makes combinations also very hard to implement. Something like InlineAutoDataAttribute would need number of generic arguments minus one constructors. |
Beta Was this translation helpful? Give feedback.
-
|
@Ergamon can you pull the latest version and try inheriting from |
Beta Was this translation helpful? Give feedback.
-
|
I'm trying out TUnit by replacing xUnit in a small project. I'm using XUnit.Combinatorial, where the use of enums as test method parameters automatically generates a test case for each value in the enum. This is what I'm able to do with XUnit.Combinatorial: public enum MyEnum { Foo, Bar, Baz }
[Theory]
[Combinatorial]
public void MyTest(MyEnum enumValue)
{
// This generates a test for Foo, Bar, and Baz
} |
Beta Was this translation helpful? Give feedback.
-
|
You can easily implement this yourself 😄 public class EnumGeneratorAttribute : NonTypedDataSourceGeneratorAttribute
{
public override IEnumerable<Func<object?[]?>> GenerateDataSources(DataGeneratorMetadata dataGeneratorMetadata)
{
if (dataGeneratorMetadata.ParameterInfos is not { Length: 1 })
{
throw new Exception("Expecting one parameter");
}
var parameterType = dataGeneratorMetadata.ParameterInfos[0].ParameterType;
if (parameterType is not { IsEnum: true })
{
throw new Exception("Expecting Enum parameter");
}
foreach (var enumValue in parameterType.GetEnumValues())
{
yield return () => [enumValue];
}
}
}public enum MyEnum { Foo, Bar, Baz }
[Test]
[EnumGenerator]
public void MyTest(MyEnum enumValue)
{
// This generates a test for Foo, Bar, and Baz
} |
Beta Was this translation helpful? Give feedback.
-
|
Okay, that doesn't look that bad. I could fork XUnit.Combinatorial into a version that works with TUnit :) |
Beta Was this translation helpful? Give feedback.
-
|
With the demise of FluentAssertions, I find myself missing the CompleteWithinAsync() and NotThrowAfterAsync assertions. Is this available and/or planned ? |
Beta Was this translation helpful? Give feedback.
-
|
Hey @thomhurst! Something like this maybe where you could specify a method in the Would that be feasible and something you can imagine as a good addition? |
Beta Was this translation helpful? Give feedback.
-
|
Should be feasible! Maybe something similar to the Arguments attribute.
|
Beta Was this translation helpful? Give feedback.
-
|
If that fits better then sure! |
Beta Was this translation helpful? Give feedback.
-
|
Give v0.10.33 a try 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Amazing! Again out there adapting stuff faster than anyone would be able to try out over the weekend 🤣 |
Beta Was this translation helpful? Give feedback.
-
|
I'd love generic type argument attributes such that I could do the following: [TypeArguments(typeof(Person), typeof(Car))]
public class MyTest<T>
{
[Test]
public async Task SomeTest()
{
// typeof(T) will be Person or Car here
}
}Or maybe even a |
Beta Was this translation helpful? Give feedback.
-
|
What do you need reflection for? |
Beta Was this translation helpful? Give feedback.
-
|
Ah yes, that works, thank you! |
Beta Was this translation helpful? Give feedback.
-
Test class with constructor parameters and non-static test data methodThis is essentially what is stated in Test class with constructor parameters and non-static test data method . While I understand the complexity of this feature, it really would be a nice thing to have. I am currently writing a small framework where I translate a C# into what is essentially a numeric-only value. This is done using source generators. In many cases I want to iterate over value inside some of these classes but also need additional test data from elsewhere: Here is an example of code that would be very nice to be able to have: [ApplicationServiceCollectionGenerator]
public class PropertyReaderTest(ApplicationServiceCollectionFixture applicationServices)
{
private readonly IEnumerable<PropertyState> _propertyStates = applicationServices.PropertyStates.Values;
private readonly IPropertyReader _propertyReader = applicationServices.PropertyReader;
private static readonly uint[] ObligatoryAttributes = new[]
{
1u, 2u, 10u, 19u, 18u
};
public IEnumerable<Func<PropertyState>> Properties()
{
return _propertyStates.Select(p => (Func<PropertyState>)(() => p));
}
[Test]
[MatrixDataSource]
public async Task CanReadProperty(
[MatrixMethod<PropertyState>(nameof(Properties))] PropertyState property,
[MatrixMethod<uint>(nameof(ObligatoryAttributes))]uint attribute)
{
var request = new ReadValueId
{
AttributeId = attribute
};
var result = _propertyReader.ReadProperty(request, property);
await Assert.That(StatusCode.IsGood(result.ResponseCode)).IsTrue();
}
}The above code, instead, generates wrongly (with value arguments (null, 0) for all combinations - any other attempt made to do something similar will not compile at all, as mentioned in the previously linked issue. The alternative to this seem to be to create a custom generator that captures both the Obligatory Attribute, the Numeric entity, and the property to read from that entity. |
Beta Was this translation helpful? Give feedback.
-
|
@TheRumle can you try v0.17.0 |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
@thomhurst This works and is such a great improvement! |
Beta Was this translation helpful? Give feedback.
-
|
Glad to hear 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Would it be possible to have "pipeline style" hooks? I have been experimenting with a piece of code that will be placed within ASP.Net or NHibernate middleware and that makes use of AsyncLocal to provide some services. It seems to work great in those pipelines in that I can register the services, invoke I've been having a nightmare trying to make collections of tests using these services using NUnit because the pre-test hooks run in a different async context to the actual tests and the post-test hooks. I've already seen that I can make this work with TUnit thanks to the FlowAsyncLocals functionality (or whatever the current name is - I think when I tried this the analyser disagreed with the rest of the code on what the name of the method is). So yay, this is already a reason to want to switch. But it would be smoother if I could write And not have to manually pair up hooks (or call the async flow method). Would such a hook be feasible or is it just too alien to the way this works? |
Beta Was this translation helpful? Give feedback.
-
|
Yeah TUnit isnt architected in this way so it wouldn't be possible without a major rewrite I don't think. But yeah I did build a method to persist Async local values between hooks and tests, so hopefully that will handle your use case! |
Beta Was this translation helpful? Give feedback.
-
|
I really like the ScenarioTests extension for XUnit. It's a really interesting approach which lends itself well to tests that often require some buildup or sequence. Under the hood, it is using source generators to "multiplex" unit tests in sequence into separate tests. It reduces the sometimes tedious work of managing test state setup. |
Beta Was this translation helpful? Give feedback.
-
|
Ew 😝 |
Beta Was this translation helpful? Give feedback.
-
|
Ok, nice; it kind of works: using System.Threading.Tasks;
public class TestCase
{
[DynamicTestBuilder]
public void TestStateMachine(DynamicTestBuilderContext context)
{
var machine = new StateMachine();
context.AddTest(
new DynamicTest<TestCase>
{
TestMethod = @class => @class.AssertNotStarted(machine), // 👈 Problem: this needs to expect a Task
TestMethodArguments = [machine],
Attributes = []
}
);
machine.Advance();
context.AddTest( // 👈 Problem: if first test fails, this one doesn't run?
new DynamicTest<TestCase>
{
TestMethod = @class => @class.AssertQueuedAfterAdvance(machine), // 👈 Problem: this needs to expect a Task
TestMethodArguments = [machine],
Attributes = []
}
);
}
public async Task AssertNotStarted(StateMachine machine)
{
await Assert.That(machine.CurrentState).IsEqualTo("not_started");
}
public async Task AssertQueuedAfterAdvance(StateMachine machine)
{
await Assert.That(machine.CurrentState).IsEqualTo("queued");
}
}
/// <summary>
/// Simple state machine
/// </summary>
public class StateMachine
{
public string CurrentState { get; set; } = "not_started";
public void Advance()
{
CurrentState = CurrentState switch
{
"not_started" => "queued",
"queued" => "starting",
"starting" => "running",
"running" => "completed",
"" => "not_started"
};
}
}Output:
While in this case, the failure of the first necessarily means the failure of the second, I think the behavior here is that even if the first test fails, it should run and report the second independently. |
Beta Was this translation helpful? Give feedback.
-
|
The second test should still be run and reported... Also it's worth noting that "AddTest" is just that, adding it to the list of test. It doesn't do or wait for execution. So both added tests will probably run concurrently. |
Beta Was this translation helpful? Give feedback.
-
|
Ah interesting, but it would seem then that it would defeat the purpose here of keeping a running context. How would it be possible to model this kind of use case from ScenarioTests, then: var calculator = new Calculator();
scenario.Fact("Calculator starts in an initial state of 0", () =>
{
Assert.Equal(0, calculator.State);
});
calculator.Add(1);
scenario.Fact("We can add a number", () =>
{
Assert.Equal(1, calculator.State);
});
calculator.Undo();
scenario.Fact("We can undo our last action if we want", () =>
{
// Facts run in isolution, any change here will not affect other facts and theories
Assert.Equal(0, calculator.State);
});I was thinking that |
Beta Was this translation helpful? Give feedback.
-
|
I'd like to piggy-back on this request to show my support. Having a feature like this would set TUnit apart. This style of testing is very useful in scenarios where a single operation can have multiple downstream side effects that you want test and explicitly document. Testing MassTransit sagas immediately comes to mind. I would love to be able to do something like this await using var serviceProvider = CreateServiceCollection();
using var scope = serviceProvider.CreateScope();
var testHarness = serviceProvider.GetRequiredService<ITestHarness>();
await testHarness.Start();
await testHarness.Bus.Publish(someMessage);
var sagaHarness = harness.GetSagaStateMachineHarness<MyStateMachine, MyStateMachineState>();
scenario.Fact("The message was consumed", async () => {
await testHarness.Consumed.Any<MyMessage>();
await sagaHarness.Consumed.Any<MyMessage>();
});
var instance = await scenario.Fact("A saga instance was created in the submitted state", async () => {
await sagaHarness.Created.Any(x => x.CorrelationId == someMessage.Id);
return sagaHarness.Created.ContainsInState(someMessage.Id, sagaHarness.StateMachine, sagaHarness.StateMachine.Submitted);
});
scenario.Fact("The customer email address was collected", async () => {
instance.CustomerEmailAddress.ShouldBe("something");
});
// etc |
Beta Was this translation helpful? Give feedback.
-
|
Is it possible to add a current index or parallel id for the current test context when it has a parallel limit? |
Beta Was this translation helpful? Give feedback.
-
|
What does a parallel ID even mean? |
Beta Was this translation helpful? Give feedback.
-
|
If I have a parallel limiter with Limit => 2. A way to check if the test is on 1 or 2. I have a service that can't handle parallel requests and initializing one per test takes too long. But I can initialize a few and then use a unused one based on the limit. |
Beta Was this translation helpful? Give feedback.
-
|
You can add an id yourself for which one started first. In a before hook, put your id in the Test context object bag |
Beta Was this translation helpful? Give feedback.
-
|
After a short hiatus from TUnit, I have returned to my project. Here is the things I found confusing or annoying after getting back (still by far the best testing framework I have worked with). I want to test that my services are registered correctly and with the correct lifetimes. I created an interface to represent matchers for services descriptors, and now want to examine my IServiceCollection. I create an iterable of service descriptor matchers that I can use to check for correct registration - this is my 'expected data'. public static IEnumerable<Func<IPartialServiceMatcher>> WantedServices { get; } =
[
()=>new GenericPartialMatcher(typeof(ISimulationBuilder<,>), ServiceLifetime.Scoped),
()=>new GenericPartialMatcher(typeof(ISimulationBuilder<,,>), ServiceLifetime.Scoped),
()=>new GenericPartialMatcher(typeof(ISimulationBuilderFactory<,>), ServiceLifetime.Singleton),
()=>new GenericPartialMatcher(typeof(ISimulationBuilderFactory<,,>), ServiceLifetime.Singleton),
()=>new ConcreteServiceWithGenericImplMatcher<ISimulationStepValidator>(Implementation: typeof(Retur
()=>new GenericPartialMatcher(typeof(ISimulationExecutor<,,>), ServiceLifetime.Transient),
()=>new GenericPartialMatcher(typeof(ISimulationExecutor<,>), ServiceLifetime.Transient),
()=>new GenericPartialMatcher(typeof(ISimulationOrchestrator<,,>), ServiceLifetime.Singleton),
()=>new GenericPartialMatcher(typeof(ISimulationOrchestrator<,>), ServiceLifetime.Singleton),
()=>new GenericPartialMatcher(typeof(ISimulationProcessorPipeline<,,>), ServiceLifetime.Singleton),
()=>new GenericPartialMatcher(typeof(ISimulationProcessorPipeline<,>), ServiceLifetime.Singleton),
];I then create a single method: [Test]
[DisplayName("A service matching $matcher has been registered")]
[XXXDataSource]
public async Task ServiceIsRegistered(IPartialServiceMatcher matcher)
{
await Assert.That(_collection.Any(matcher.Equals)).IsTrue();
}but could not for the life of me figure out how to inject property data into the method. DataSourceAttribute to inject data from propertiesLooking through the types of DataSource attributes, it was not immediately obvious to me whether it is possible to use a property to inject the elements Okay, I then want to test more things - I figured it would be nice to make sure the same generic instance types has the same lifetime. So I create a test: public async Task ServicesHasWantedLifetime(IEnumerable<IPartialServiceMatcher> matchers, ServiceLifetime lifetime)
{
var wantedServices = matchers.Where(e => e.Lifetime == lifetime);
using (Assert.Multiple())
{
var provider = _collection.BuildServiceProvider();
foreach (var serviceDescriptor in wantedServices)
{
var foundService = provider.GetService(serviceDescriptor.ServiceType);
await Assert.That(foundService).IsNotNull().Because("We want to construct the service as a singleton");
}
}
}I then tried to figure out which datasource attribute I could use to inject data from WantedServices (which were refactored to a List of elements and a List<Func>) . However, I could not see a good way of combining multiple data sources. This lead me to my next wanted feature: An intuitive Api for combining data sources
|
Beta Was this translation helpful? Give feedback.
-
|
Would it be possible to add support for Junit test report format ? I think only trx is available for now. |
Beta Was this translation helpful? Give feedback.
-
|
Should be something you can add yourself. In an [After(TestSession)] hook, you have a context object with all the tests and all their results. Iterate through and write your file in your desired format. |
Beta Was this translation helpful? Give feedback.
-
|
Of course, I could add it myself. But since GitLab only supports JUnit, I think this should be provided as a built-in feature rather than something everyone has to implement on their own — similar to what xUnit v3 offers. I ended up using this tool in my ci-cd script : Great lib by the way. Thanks for all your efforts developping such a cool lib |
Beta Was this translation helpful? Give feedback.
-
|
There's an issue asking for this support in |
Beta Was this translation helpful? Give feedback.
-
|
Just to update other readers, this was added a while back and makes reports in Gitlab easier to read |
Beta Was this translation helpful? Give feedback.
-
|
Looking at migrating from NUnit, a few things the migration code-fixes couldn't handle: (all of which are theoretically fixable, but require rewriting every test method)
|
Beta Was this translation helpful? Give feedback.
-
|
@thomhurst The using gets added, but the extra properties are still being removed from TestCases. // before
[Test(Description = "Description")]
[TestCase(5, ExpectedResult = true, TestName = "Name #1", Description = "Description #1")]
[TestCase(1, ExpectedResult = false, TestName = "Name #2", Description = "Description #2")]
public bool TestFoo(int intArg) => intArg == 5;
// after
using System.Threading.Tasks;
// ...
[Test(Description = "Description")]
[Arguments(5, true)]
[Arguments(1, false)]
public async Task TestFoo(int intArg, bool expected)
{
await Assert.That(intArg == 5).IsEqualTo(expected);
}Additionally, it seems that now migrating TestCases with any properties but without an ExpectedResult (void return), the code-fix just fails entirely. [TestCase("", TestName = "Name")]
public void TestVoidFoo(string arg) => Assert.Pass();Throws this error roslyn stacktrace
"Convert NUnit code to TUnit" System.InvalidOperationException: Unexpected false - file CSharpTriviaFormatter.cs line 224 at Microsoft.CodeAnalysis.Contract.Fail(String message, Int32 lineNumber, String filePath) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Dependencies\Contracts\Contract.cs:line 161 at Microsoft.CodeAnalysis.CSharp.Formatting.CSharpTriviaFormatter.TryFormatMultiLineCommentTrivia(LineColumn lineColumn, SyntaxTrivia trivia, SyntaxTrivia& result) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\CSharp\Formatting\Engine\Trivia\CSharpTriviaFormatter.cs:line 224 at Microsoft.CodeAnalysis.CSharp.Formatting.CSharpTriviaFormatter.Format(LineColumn lineColumn, SyntaxTrivia trivia, ArrayBuilder`1 changes, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\CSharp\Formatting\Engine\Trivia\CSharpTriviaFormatter.cs:line 266 at Microsoft.CodeAnalysis.Formatting.AbstractTriviaFormatter.FormatFirstTriviaAndWhitespaceAfter[T](LineColumn lineColumnBeforeTrivia1, SyntaxTrivia trivia1, LineColumnDelta existingWhitespaceBetween, SyntaxTrivia trivia2, Formatter`1 format, WhitespaceAppender`1 addWhitespaceTrivia, ArrayBuilder`1 changes, Boolean implicitLineBreak, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\Formatting\TriviaEngine\AbstractTriviaFormatter.cs:line 381 at Microsoft.CodeAnalysis.Formatting.AbstractTriviaFormatter.FormatTrivia[T](Formatter`1 formatter, WhitespaceAppender`1 whitespaceAdder, ArrayBuilder`1 changes, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\Formatting\TriviaEngine\AbstractTriviaFormatter.cs:line 361 at Microsoft.CodeAnalysis.Formatting.AbstractTriviaFormatter.FormatToTextChanges(CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\Formatting\TriviaEngine\AbstractTriviaFormatter.cs:line 269 at Microsoft.CodeAnalysis.CSharp.Formatting.TriviaDataFactory.FormattedComplexTrivia..ctor(FormattingContext context, ChainedFormattingRules formattingRules, SyntaxToken token1, SyntaxToken token2, Int32 lineBreaks, Int32 spaces, String originalString, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\CSharp\Formatting\Engine\Trivia\TriviaDataFactory.FormattedComplexTrivia.cs:line 39 at Microsoft.CodeAnalysis.CSharp.Formatting.TriviaDataFactory.ComplexTrivia.Format(FormattingContext context, ChainedFormattingRules formattingRules, Int32 lines, Int32 spaces, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\CSharp\Formatting\Engine\Trivia\TriviaDataFactory.ComplexTrivia.cs:line 42 at Microsoft.CodeAnalysis.CSharp.Formatting.TriviaDataFactory.ComplexTrivia.Format(FormattingContext context, ChainedFormattingRules formattingRules, Action`3 formattingResultApplier, CancellationToken cancellationToken, Int32 tokenPairIndex) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\CSharp\Formatting\Engine\Trivia\TriviaDataFactory.ComplexTrivia.cs:line 98 at Microsoft.CodeAnalysis.Formatting.AbstractFormatEngine.Format(CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\Formatting\Engine\AbstractFormatEngine.cs:line 137 at Microsoft.CodeAnalysis.CSharp.Formatting.CSharpSyntaxFormatting.Format(SyntaxNode node, SyntaxFormattingOptions options, ImmutableArray`1 formattingRules, SyntaxToken startToken, SyntaxToken endToken, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\CSharp\Formatting\CSharpSyntaxFormatting.cs:line 49 at Microsoft.CodeAnalysis.Formatting.AbstractSyntaxFormatting.GetFormattingResult(SyntaxNode node, IEnumerable`1 spans, SyntaxFormattingOptions options, ImmutableArray`1 rules, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Compiler\Core\Formatting\AbstractSyntaxFormatting.cs:line 62 at Microsoft.CodeAnalysis.Formatting.FormatterShared.Format(ISyntaxFormatting syntaxFormatting, SyntaxNode node, IEnumerable`1 spans, SyntaxFormattingOptions options, ImmutableArray`1 rules, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Workspace\Core\Formatting\FormatterShared.cs:line 34 at Microsoft.CodeAnalysis.Formatting.FormatterShared.Format(ISyntaxFormatting syntaxFormatting, SyntaxNode node, SyntaxAnnotation annotation, SyntaxFormattingOptions options, ImmutableArray`1 rules, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Workspace\Core\Formatting\FormatterShared.cs:line 31 at Microsoft.CodeAnalysis.Formatting.FormatterShared.FormatAsync(ISyntaxFormatting syntaxFormatting, Document document, SyntaxAnnotation annotation, SyntaxFormattingOptions options, ImmutableArray`1 rules, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Workspace\Core\Formatting\FormatterShared.cs:line 27 at Microsoft.CodeAnalysis.CodeCleanup.CodeCleanupHelpers.CleanupSyntaxAsync(Document document, CodeCleanupOptions options, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\SharedUtilitiesAndExtensions\Workspace\Core\CodeCleanup\CodeCleanupHelpers.cs:line 24 at Microsoft.CodeAnalysis.CodeActions.CodeAction.c. b__78_1>d.MoveNext() in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\Core\Portable\CodeActions\CodeAction_Cleanup.cs:line 203 --- End of stack trace from previous location --- at Microsoft.CodeAnalysis.Threading.ProducerConsumer`1.c__DisplayClass11_0`3. b__2>d.MoveNext() in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Dependencies\Threading\ProducerConsumer.cs:line 238 --- End of stack trace from previous location --- at System.Threading.Tasks.RoslynParallelExtensions.NetFramework.c__9`1. b__9_0>d.MoveNext() in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Dependencies\Threading\ParallelExtensions.NetFramework.cs:line 328 --- End of stack trace from previous location --- at Microsoft.CodeAnalysis.Threading.ProducerConsumer`1.c__14`2. b__14_3>d.MoveNext() in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Dependencies\Threading\ProducerConsumer.cs:line 367 --- End of stack trace from previous location --- at Microsoft.CodeAnalysis.Threading.ProducerConsumer`1.PerformActionAndCloseWriterAsync[TArgs](Func`3 action, TArgs args, ChannelWriter`1 writer, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Dependencies\Threading\ProducerConsumer.cs:line 384 at Microsoft.CodeAnalysis.Threading.ProducerConsumer`1.RunChannelAsync[TArgs,TResult](ProducerConsumerOptions options, Func`4 produceItems, Func`4 consumeItems, TArgs args, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Dependencies\Threading\ProducerConsumer.cs:line 344 at Microsoft.CodeAnalysis.Threading.ProducerConsumer`1.RunParallelAsync[TSource,TArgs](IAsyncEnumerable`1 source, Func`5 produceItems, TArgs args, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Dependencies\Threading\ProducerConsumer.cs:line 211 at Microsoft.CodeAnalysis.CodeActions.CodeAction.c__DisplayClass78_0. g__RunParallelCleanupPassAsync|0>d.MoveNext() in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\Core\Portable\CodeActions\CodeAction_Cleanup.cs:line 187 --- End of stack trace from previous location --- at Microsoft.CodeAnalysis.CodeActions.CodeAction.RunCleanupPassesInOrderAsync(Solution solution, ImmutableArray`1 documentIdsAndOptions, IProgress`1 progress, ImmutableArray`1 passes, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\Core\Portable\CodeActions\CodeAction_Cleanup.cs:line 175 at Microsoft.CodeAnalysis.CodeActions.CodeAction.CleanSyntaxAndSemanticsAsync(Solution originalSolution, Solution changedSolution, IProgress`1 progress, ImmutableArray`1 passes, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\Core\Portable\CodeActions\CodeAction_Cleanup.cs:line 121 at Microsoft.CodeAnalysis.CodeActions.CodeAction.PostProcessChangesAsync(Solution originalSolution, Solution changedSolution, IProgress`1 progress, CodeActionCleanup cleanup, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\Core\Portable\CodeActions\CodeAction_Cleanup.cs:line 104 at Microsoft.CodeAnalysis.CodeActions.CodeAction.PostProcessAsync(Solution originalSolution, IEnumerable`1 operations, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\Core\Portable\CodeActions\CodeAction.cs:line 435 at Microsoft.CodeAnalysis.CodeActions.CodeAction.GetOperationsCoreAsync(Solution originalSolution, IProgress`1 progress, CancellationToken cancellationToken) in Z:\BuildAgent\work\3b7ce003563d6f8f\src\Workspaces\Core\Portable\CodeActions\CodeAction.cs:line 251 at JetBrains.Roslyn.Worker.Features.Analyzers.Impl.CodeActions.CodeActionService.GetOperationsSafeAsync(CodeAction codeAction, CancellationToken cancellationToken) |
Beta Was this translation helpful? Give feedback.
-
|
I see you did some more work here (I'm amazed and grateful for your responsiveness!) Please, would you consider supporting some of these properties on the If you're really set against that, I can roll my own implementation for my team, but then I'd ask for (Also, if you want me to open a PR for some/any of this, I'm more than happy to, I just want to make sure you're amenable.) |
Beta Was this translation helpful? Give feedback.
-
|
@AvremelM try 1.8.1 |
Beta Was this translation helpful? Give feedback.
-
|
Amazing! 🙏 Some notes: // before
[Test(Description = "Description")]
[TestCase(5, ExpectedResult = true, TestName = "Name #1", Description = "Description #1")]
[TestCase(1, ExpectedResult = false, TestName = "Name #2", Description = "Description #2")]
public bool TestFoo(int intArg) => intArg == 5;
// after
[Test(Description = "Description")] // <--- Compiler Error
[Arguments(5, true, DisplayName = "Name #1")]
[Arguments(1, false, DisplayName = "Name #2")] // <--- Description value lost
[Property("Description", "Description #1")] // <--- Pulled Description value from first TestCase instead of `TestAttribute`
public async Task TestFoo(int intArg, bool expected)
{
await Assert.That(intArg == 5).IsEqualTo(expected);
}Also, I see that Claude in #4202 claims that migration support was added for NUnit's |
Beta Was this translation helpful? Give feedback.
-
|
These should hopefully be better now |
Beta Was this translation helpful? Give feedback.
-
|
Is it possible to have rough collection equality assertion as a first-class extension method? var target = new[] { 1, 4, 2, 5, 3 };
_ = await Assert.That(target).IsSequentiallyEqualTo([1, 4, 2, 5, 3]); |
Beta Was this translation helpful? Give feedback.
-
|
This should be easy enough to create yourself with a |
Beta Was this translation helpful? Give feedback.
-
|
It would be nice to have an attribute that lets you override the class name which functions like [ClassName("A Tests")]
public class ClassA
{
[Test]
public async Task A1()
{
...
}
...
} |
Beta Was this translation helpful? Give feedback.
-
|
Yeah I do want to do something like this - But the current Test Explorer doesn't support it :( I'm trying to get microsoft to make it more extensible so test framework authors can hook into and control its display |
Beta Was this translation helpful? Give feedback.
-
Custom class data source attributeI am working on a test framework design, where I can do a single assembly scanning and then find some adapter that can be used by the rest of my framework. I want to reuse the existing behaviour of Here is the example I want to have working. I made comments with what I believe I need to have working: public sealed class AdaptableFixtureAttribute<T> : DataSourceGeneratorAttribute<ISimulationFixture<T>>
{
private readonly DataSourceGeneratorAttribute<ISimulationFixture<T>> _classDataSource;
public AdaptableFixtureAttribute(
SharedType shared = SharedType.PerTestSession,
string key = FixtureKeys.ReadOnlyFixture)
{
var adapter = FrameworkAdapter.AdapterInstance;
var serverAdapter = adapter.GetSimulationServerType();
var genericType = typeof(AssemblyScanningFixture<,>).MakeGenericType(serverAdapter, typeof(T));
var innerSource = typeof(ClassDataSourceAttribute<>).MakeGenericType(genericType);
_classDataSource = (DataSourceGeneratorAttribute<ISimulationFixture<T>>)
innerSource.GetConstructor(Type.EmptyTypes)!.Invoke([]);
//here I need to be able to assign the SharedType and key to the datasource
}
protected override IEnumerable<Func<ISimulationFixture<T>>> GenerateDataSources(DataGeneratorMetadata dataGeneratorMetadata)
{
//Here I need to be able to forward the call directly to _classDataSource
//but cannot access it, since it is a protected member.
return [];
}
}The ideal usecase scenario is that I get access to the GenerateDataSources of the What are the chances of something like this being made available? What would the repercussions of gaining access to those fields? |
Beta Was this translation helpful? Give feedback.
-
|
@TheRumle Sorry I forgot to reply to this. I opened up |
Beta Was this translation helpful? Give feedback.
-
|
It would be incredible if the OpenTelemetry captured when running against an Aspire Fixture was captured as part of the TUnit html report. I suspect it would be difficult to implement at the moment, given Aspire doesn't expose the OTEL traces it collects in any way. I'm following the discussion on the Aspire repo about that here: microsoft/aspire#2897. But they only seem to be work arounds at the moment. I'd be happy to contribute to this if it was possible. But I suspect having the TUnit process start a HTTP server to intercept the OTEL requests wouldn't be something you would want to add to the project - and I can't see another way to achieve it at the moment. |
Beta Was this translation helpful? Give feedback.
-
|
If you've got any ideas I'm open to them. Aspire is trickier because it runs out of process |
Beta Was this translation helpful? Give feedback.
-
.net framework supportIt would make the move to TUnit a no-brainer if it supported .net frameowrk as well |
Beta Was this translation helpful? Give feedback.
-
|
It does! You just have to also install the Polyfill package to add some types used by the compiler that were only added in newer .NET versions |
Beta Was this translation helpful? Give feedback.
-
|
Oh, very cool - thanks! |
Beta Was this translation helpful? Give feedback.
and others
Uh oh!
There was an error while loading. Please reload this page.
-
Is there a feature that other frameworks provide that TUnit doesn't?
Is there a feature that they don't support but you wish they did?
I'm open to suggestions on anything that'd help make TUnit meet your testing needs.
Beta Was this translation helpful? Give feedback.
All reactions