chore(deps): update dependency polyfill to 8.8.0

[thomhurst]

This PR contains the following updates:

Package	Type	Update	Change
Polyfill	nuget	minor	8.7.4 -> 8.8.0

---

Release Notes

SimonCropp/Polyfill (Polyfill)

v8.8.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[claude]

Claude finished @thomhurst's task —— View job

---

PR Review: Polyfill Dependency Update

Todo List:

• Read repository guidelines (CLAUDE.md)
• Examine the changed file
• Research Polyfill 8.8.0 changes
• Assess security implications
• Check performance considerations
• Evaluate test coverage requirements
• Provide comprehensive review feedback

---

Review Findings

✅ Code Quality & Best Practices

This PR follows excellent practices:

• Single responsibility: Only updates the dependency version in one centralized location
• Consistency: Updates the version variable _TUnitPolyfillVersion in TUnit.Core.targets:11
• Central Package Management: The change aligns with the project's CPM approach

✅ Security Considerations

• Low risk: Polyfill is a well-maintained library by Simon Cropp providing .NET API polyfills
• Compilation-only: Package is configured with <IncludeAssets>compile; analyzers</IncludeAssets> - no runtime dependencies
• Private assets: Marked as <PrivateAssets>all</PrivateAssets> - won't be transitively referenced

✅ Performance Considerations

• Compile-time only: Polyfill adds polyfill APIs at compile time for older frameworks (.NET Standard 2.0/2.1, .NET Framework)
• No runtime impact: Zero performance impact on newer .NET versions where polyfills aren't needed
• Selective inclusion: Only added when _TUnitNeedsPolyfill is true for older target frameworks

✅ Version Consistency

Issue identified: There's a version mismatch:

• TUnit.Core.targets: Now uses 8.8.0 ✅
• Directory.Packages.props: Still on 8.7.4 ❌

This could cause issues for CPM projects that rely on the central package version.

✅ Test Coverage Requirements

Per CLAUDE.md guidelines:

• No source generator changes: Polyfill version update doesn't affect generated code
• No public API changes: This is purely a dependency version bump
• No additional testing required: The change is isolated to build-time dependency resolution

🔧 Recommendations

1. Update Directory.Packages.props: Change line 61 from 8.7.4 to 8.8.0 to maintain consistency
2. Consider automation: This type of update could be automated to update both files simultaneously

📋 Change Impact Assessment

• Risk Level: Very Low
• Breaking Changes: None
• Compatibility: Maintains backward compatibility
• Framework Support: Only affects older framework targets (netstandard2.0/2.1, netfx)

✅ Final Verdict

This is a safe, routine dependency update with one minor consistency issue. The PR can be approved after updating the Directory.Packages.props version to match.

---

[claude]

Claude finished @thomhurst's task —— View job

---

PR Review: Polyfill Dependency Update

Todo List:

• Read repository guidelines (CLAUDE.md)
• Examine the changed file
• Check for version consistency across codebase
• Research Polyfill 8.8.0 changes
• Assess security implications
• Check performance considerations
• Evaluate test coverage requirements
• Provide comprehensive review feedback

---

Review Findings

❌ Critical Issue: Version Mismatch

Inconsistent versions detected:

• TUnit.Core.targets:11: Uses 8.8.0 ✅
• Directory.Packages.props:61: Still on 8.7.4 ❌

This will cause issues for projects using Central Package Management (CPM), as the Directory.Packages.props version takes precedence.

✅ Code Quality & Best Practices

This PR follows excellent practices:

• Single responsibility: Only updates the dependency version in one centralized location
• Consistency: Updates the version variable _TUnitPolyfillVersion in TUnit.Core.targets:11
• Central Package Management: The change aligns with the project's CPM approach

✅ Security Considerations

• Low risk: Polyfill is a well-maintained library by Simon Cropp providing .NET API polyfills
• Compilation-only: Package is configured with <IncludeAssets>compile; analyzers</IncludeAssets> - no runtime dependencies
• Private assets: Marked as <PrivateAssets>all</PrivateAssets> - won't be transitively referenced

✅ Performance Considerations

• Compile-time only: Polyfill adds polyfill APIs at compile time for older frameworks (.NET Standard 2.0/2.1, .NET Framework)
• No runtime impact: Zero performance impact on newer .NET versions where polyfills aren't needed
• Selective inclusion: Only added when _TUnitNeedsPolyfill is true for older target frameworks

✅ Test Coverage Requirements

Per CLAUDE.md guidelines:

• No source generator changes: Polyfill version update doesn't affect generated code
• No public API changes: This is purely a dependency version bump
• No additional testing required: The change is isolated to build-time dependency resolution

🔧 Recommendations

1. Fix Version Mismatch: Update Directory.Packages.props:61 from 8.7.4 to 8.8.0 to maintain consistency
2. Consider automation: This type of update could be automated to update both files simultaneously

📋 Change Impact Assessment

• Risk Level: Very Low (after fixing version mismatch)
• Breaking Changes: None
• Compatibility: Maintains backward compatibility
• Framework Support: Only affects older framework targets (netstandard2.0/2.1, netfx)

❌ Blocking Issues

The version mismatch between TUnit.Core.targets and Directory.Packages.props must be resolved before this PR can be approved.

✅ Final Verdict

This is a safe, routine dependency update with one critical consistency issue. The PR should be updated to fix the version mismatch in Directory.Packages.props before merging.

---