chore(deps): update dependency polyfill to v10#5418
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Code Review: Polyfill v9.24.1 → v10.0.0
Summary: Straightforward major-version dependency bump of the Polyfill source-generator package, touching a single line in TUnit.Core/TUnit.Core.targets.
Analysis
The change is safe. Here's why:
-
C# 14 syntax in v10.0.0 — The breaking change that warrants a major version is the migration of
Directorypolyfills to the newextension(Directory)syntax (C# 14). TUnit already hasLangVersion = preview, so this compiles fine. -
Compile-time only, no runtime impact — The package is included as
compile; analyzersonly withPrivateAssets=all, so no runtime binary is affected. There is no risk of a deploy-time regression. -
Narrow injection scope — The
_TUnitNeedsPolyfillcondition gates injection tonetstandard2.0,netstandard2.1, and.NETFrameworktargets only. TUnit's own multi-targets (net8.0;net9.0;net10.0) are unaffected; the polyfill is only injected for downstream consumers on legacy frameworks. -
No breaking API changes — The release notes list only additive changes: new
IndexOfAnyExcept/LastIndexOfAnyExceptpolyfills and the internal syntax migration. Nothing removed. -
Automerge is already enabled — Standard Renovate dependency-update flow.
No concerns. LGTM ✓
e14beb5 to
43bcf07
Compare
There was a problem hiding this comment.
Code Review Update
No changes since the previous review — the diff remains a single-line version bump in TUnit.Core/TUnit.Core.targets.
All prior analysis still applies:
- Compile-time only — no runtime impact; package is injected with
PrivateAssets=all. - C# 14 syntax in v10.0.0 (the
extension(Directory)migration) is compatible becauseLangVersion = previewis already set project-wide. - Additive changes only — new
IndexOfAnyExcept/LastIndexOfAnyExceptpolyfills; nothing removed. - Narrow scope — polyfill injection is gated to
netstandard2.0,netstandard2.1, and.NETFrameworktargets; TUnit's ownnet8.0;net9.0;net10.0builds are unaffected.
LGTM. Safe to merge.
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.28.7 to 1.29.0. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.29.0 <!-- Release notes generated using configuration in .github/release.yml at v1.29.0 --> ## What's Changed ### Other Changes * 🤖 Update Mock Benchmark Results by @thomhurst in thomhurst/TUnit#5420 * fix(mocks): resolve build errors when mocking Azure SDK clients by @thomhurst in thomhurst/TUnit#5440 * fix: deduplicate virtual hook overrides across class hierarchy (#5428) by @thomhurst in thomhurst/TUnit#5441 * fix(mocks): unique __argArray locals per event in RaiseEvent dispatch (#5423) by @thomhurst in thomhurst/TUnit#5442 * refactor(mocks): extract MockTypeModel.Visibility helper by @thomhurst in thomhurst/TUnit#5443 * fix(mocks): preserve nullable annotations on generated event implementations by @thomhurst in thomhurst/TUnit#5444 * fix(mocks): preserve nullability on event handler types (#5425) by @thomhurst in thomhurst/TUnit#5445 ### Dependencies * chore(deps): update tunit to 1.28.7 by @thomhurst in thomhurst/TUnit#5416 * chore(deps): update dependency polyfill to v10 by @thomhurst in thomhurst/TUnit#5417 * chore(deps): update dependency polyfill to v10 by @thomhurst in thomhurst/TUnit#5418 * chore(deps): update dependency mockolate to 2.4.0 by @thomhurst in thomhurst/TUnit#5431 * chore(deps): update mstest to 4.2.1 by @thomhurst in thomhurst/TUnit#5433 * chore(deps): update dependency microsoft.net.test.sdk to 18.4.0 by @thomhurst in thomhurst/TUnit#5435 * chore(deps): update microsoft.testing to 2.2.1 by @thomhurst in thomhurst/TUnit#5432 * chore(deps): update dependency microsoft.testing.extensions.codecoverage to 18.6.2 by @thomhurst in thomhurst/TUnit#5437 * chore(deps): update dependency @docusaurus/theme-mermaid to ^3.10.0 by @thomhurst in thomhurst/TUnit#5438 * chore(deps): update docusaurus to v3.10.0 by @thomhurst in thomhurst/TUnit#5439 **Full Changelog**: thomhurst/TUnit@v1.28.7...v1.29.0 Commits viewable in [compare view](thomhurst/TUnit@v1.28.7...v1.29.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
9.24.1→10.0.0Release Notes
SimonCropp/Polyfill (Polyfill)
v10.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.