Conversation
There was a problem hiding this comment.
Code Review
This is a Renovate bot PR bumping TUnit.AspNetCore from 1.37.24 → 1.37.35 in Directory.Packages.props.
What's in 1.37.35
Per the release notes, the intermediate versions include:
- fix(aspire): preserve user-supplied OTLP endpoint (#4818)
- feat(aspire): emit client spans for HTTP
- Several dependency bumps (dotnet-sdk, aspnetcore, aspire, microsoft.extensions, microsoft.net.test.sdk)
Observation: Version Mismatch Within TUnit Family
The change leaves the TUnit package family in a split state:
<PackageVersion Include="TUnit" Version="1.37.24" />
<PackageVersion Include="TUnit.AspNetCore" Version="1.37.35" /> <!-- bumped -->
<PackageVersion Include="TUnit.Core" Version="1.37.24" />
<PackageVersion Include="TUnit.Engine" Version="1.37.24" />
<PackageVersion Include="TUnit.Assertions" Version="1.37.24" />If TUnit.AspNetCore has a hard dependency on TUnit.Core >= 1.37.35, this could cause a runtime conflict. It's worth confirming that TUnit.AspNetCore 1.37.35 is compatible with TUnit.Core/Engine 1.37.24, or whether all packages should be bumped together.
If the packages are independently versioned and TUnit.AspNetCore carries its own release cadence separate from the core packages, this is fine as-is. But if they share a tight internal API surface (which is common for framework extension packages), keeping versions in sync avoids subtle breakage.
Change Itself
The single-line diff is correct and minimal. No concerns with the mechanical change.
Verdict: Approve with the caveat above — worth a quick sanity-check that TUnit.AspNetCore 1.37.35 does not require a newer TUnit.Core than 1.37.24.
There was a problem hiding this comment.
Code Review
This is a Renovate bot PR bumping TUnit.AspNetCore from 1.37.24 → 1.37.35 in Directory.Packages.props.
What's in 1.37.35
Per the release notes, the intermediate versions include:
- fix(aspire): preserve user-supplied OTLP endpoint (#4818)
- feat(aspire): emit client spans for HTTP
- Several dependency bumps (dotnet-sdk, aspnetcore, aspire, microsoft.extensions, microsoft.net.test.sdk)
Observation: Version Mismatch Within TUnit Family
The change leaves the TUnit package family in a split state:
<PackageVersion Include="TUnit" Version="1.37.24" />
<PackageVersion Include="TUnit.AspNetCore" Version="1.37.35" /> <!-- bumped -->
<PackageVersion Include="TUnit.Core" Version="1.37.24" />
<PackageVersion Include="TUnit.Engine" Version="1.37.24" />
<PackageVersion Include="TUnit.Assertions" Version="1.37.24" />If TUnit.AspNetCore has a hard dependency on TUnit.Core >= 1.37.35, this could cause a runtime conflict. It's worth confirming that TUnit.AspNetCore 1.37.35 is compatible with TUnit.Core/Engine 1.37.24, or whether all packages should be bumped together.
If the packages are independently versioned and TUnit.AspNetCore carries its own release cadence separate from the core packages, this is fine as-is. But if they share a tight internal API surface (which is common for framework extension packages), keeping versions in sync avoids subtle breakage.
Change Itself
The single-line diff is correct and minimal. No concerns with the mechanical change.
Verdict: Approve with the caveat above — worth a quick sanity-check that TUnit.AspNetCore 1.37.35 does not require a newer TUnit.Core than 1.37.24.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
5e171b1 to
3ef25cc
Compare
There was a problem hiding this comment.
Code Review: Dependency Bump — TUnit 1.37.24 → 1.37.35
Previous Review Follow-up: An earlier review from this session raised a version mismatch concern; that was based on a misreading of the diff. The actual diff correctly bumps all 7 TUnit family packages together, so there is no concern there.
Summary
This is a Renovate Bot–generated dependency bump updating the entire TUnit package family (7 packages) from 1.37.24 to 1.37.35.
What Changed
| File | Change |
|---|---|
Directory.Packages.props |
Central version pin for 6 packages bumped |
TUnit.Templates/content/*/\*.csproj/.fsproj/.vbproj |
Pinned versions in 5 template projects bumped |
Analysis
✅ Version coherence — All 7 packages (TUnit, TUnit.Assertions, TUnit.Assertions.FSharp, TUnit.AspNetCore, TUnit.Core, TUnit.Engine, TUnit.Playwright) are bumped in perfect lockstep. No version splits.
✅ Template parity — The template projects under TUnit.Templates/content/ are updated in sync, so newly scaffolded projects will use the same version as the monorepo itself.
✅ Central version management respected — Projects using Central Package Management (Directory.Packages.props) are updated at the root, not scattered across individual .csproj files. Template projects that cannot use CPM are updated directly — both patterns are correct.
✅ Release notes are substantive — The 1.37.35 release includes a bug fix for Aspire OTLP endpoint preservation (#4818), new HTTP client span emission, and a solution file addition. All are straightforward improvements with no breaking changes.
✅ Codacy clean — No new issues or complexity introduced.
Verdict
This is a clean, well-formed dependency update. The lockstep versioning strategy across the TUnit family is correctly applied. No concerns.
3ef25cc to
59a33bc
Compare
There was a problem hiding this comment.
Code Review: Dependency Bump — TUnit 1.37.24 → 1.37.35
Previous review context: Earlier reviews in this session are already on record. This is a confirming review for the current head commit.
Summary
Renovate Bot–generated patch bump of all 7 TUnit family packages from 1.37.24 → 1.37.35. This is a clean, low-risk update.
Checklist
- Version coherence — All 7 packages (
TUnit,TUnit.Assertions,TUnit.Assertions.FSharp,TUnit.AspNetCore,TUnit.Core,TUnit.Engine,TUnit.Playwright) move in perfect lockstep. No split versions. - Central Package Management —
Directory.Packages.propsis the single source of truth for the monorepo. Updated correctly. - Template parity — The 5 template
.csproj/.fsproj/.vbprojfiles underTUnit.Templates/content/are updated in sync, so scaffolded projects get the same version. - Release notes are substantive — 1.37.35 includes a bug fix for Aspire OTLP endpoint preservation (#4818), new HTTP client span emission for Aspire, and a solution file addition. No breaking changes.
- Codacy clean — 0 new issues, 0 complexity delta.
Verdict
No concerns. The diff is mechanically correct and the release content is safe to adopt.
59a33bc to
78ca947
Compare
There was a problem hiding this comment.
Code Review — Routine Dependency Bump
This is a clean, routine Renovate Bot patch bump of all 7 TUnit family packages from 1.37.24 → 1.37.36.
Checklist
- Version coherence — All 7 packages (
TUnit,TUnit.Assertions,TUnit.Assertions.FSharp,TUnit.AspNetCore,TUnit.Core,TUnit.Engine,TUnit.Playwright) are bumped in perfect lockstep. No mismatches. - CPM correctness —
Directory.Packages.propsis the authoritative source for the monorepo, updated correctly. - Template parity — The 5 template project files (
.fsproj,.csproj,.vbproj) are updated with direct version pins, which is correct since they live outside the CPM boundary. - Release notes — v1.37.25–v1.37.36 contain bug fixes (telemetry duplicate spans, Aspire OTLP endpoint), one additive feature (HTTP client spans for Aspire), and dependency updates. No breaking changes.
- Previous reviews addressed — The earlier false concern about a version mismatch was already corrected and confirmed clean in subsequent reviews.
No issues found. The change is mechanical, safe, and follows the repo's established dependency management patterns.
Approved.
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.37.10 to 1.39.0. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.39.0 <!-- Release notes generated using configuration in .github/release.yml at v1.39.0 --> ## What's Changed ### Other Changes * perf(mocks): shrink MethodSetup + cache stateless matchers by @thomhurst in thomhurst/TUnit#5669 * fix(mocks): handle base classes with explicit interface impls (#5673) by @thomhurst in thomhurst/TUnit#5674 * fix(mocks): implement indexer in generated mock (#5676) by @thomhurst in thomhurst/TUnit#5683 * fix(mocks): disambiguate IEquatable<T>.Equals from object.Equals (#5675) by @thomhurst in thomhurst/TUnit#5680 * fix(mocks): escape C# keyword identifiers at all emit sites (#5679) by @thomhurst in thomhurst/TUnit#5684 * fix(mocks): emit [SetsRequiredMembers] on generated mock ctor (#5678) by @thomhurst in thomhurst/TUnit#5682 * fix(mocks): skip MockBridge for class targets with static-abstract interfaces (#5677) by @thomhurst in thomhurst/TUnit#5681 * chore(mocks): regenerate source generator snapshots by @thomhurst in thomhurst/TUnit#5691 * perf(engine): collapse async state-machine layers on hot test path (#5687) by @thomhurst in thomhurst/TUnit#5690 * perf(engine): reduce lock contention in scheduling and hook caches (#5686) by @thomhurst in thomhurst/TUnit#5693 * fix(assertions): prevent implicit-to-string op from NREing on null (#5692) by @thomhurst in thomhurst/TUnit#5696 * perf(engine/core): reduce per-test allocations (#5688) by @thomhurst in thomhurst/TUnit#5694 * perf(engine): reduce message-bus contention on test start (#5685) by @thomhurst in thomhurst/TUnit#5695 ### Dependencies * chore(deps): update tunit to 1.37.36 by @thomhurst in thomhurst/TUnit#5667 * chore(deps): update verify to 31.16.2 by @thomhurst in thomhurst/TUnit#5699 **Full Changelog**: thomhurst/TUnit@v1.37.36...v1.39.0 ## 1.37.36 <!-- Release notes generated using configuration in .github/release.yml at v1.37.36 --> ## What's Changed ### Other Changes * fix(telemetry): remove duplicate HTTP client spans by @thomhurst in thomhurst/TUnit#5668 **Full Changelog**: thomhurst/TUnit@v1.37.35...v1.37.36 ## 1.37.35 <!-- Release notes generated using configuration in .github/release.yml at v1.37.35 --> ## What's Changed ### Other Changes * Add TUnit.TestProject.Library to the TUnit.Dev.slnx solution file by @Zodt in thomhurst/TUnit#5655 * fix(aspire): preserve user-supplied OTLP endpoint (#4818) by @thomhurst in thomhurst/TUnit#5665 * feat(aspire): emit client spans for HTTP by @thomhurst in thomhurst/TUnit#5666 ### Dependencies * chore(deps): update dependency dotnet-sdk to v10.0.203 by @thomhurst in thomhurst/TUnit#5656 * chore(deps): update microsoft.aspnetcore to 10.0.7 by @thomhurst in thomhurst/TUnit#5657 * chore(deps): update tunit to 1.37.24 by @thomhurst in thomhurst/TUnit#5659 * chore(deps): update microsoft.extensions to 10.0.7 by @thomhurst in thomhurst/TUnit#5658 * chore(deps): update aspire to 13.2.3 by @thomhurst in thomhurst/TUnit#5661 * chore(deps): update dependency microsoft.net.test.sdk to 18.5.0 by @thomhurst in thomhurst/TUnit#5664 ## New Contributors * @Zodt made their first contribution in thomhurst/TUnit#5655 **Full Changelog**: thomhurst/TUnit@v1.37.24...v1.37.35 ## 1.37.24 <!-- Release notes generated using configuration in .github/release.yml at v1.37.24 --> ## What's Changed ### Other Changes * docs: add Tluma Ask AI widget to Docusaurus site by @thomhurst in thomhurst/TUnit#5638 * Revert "chore(deps): update dependency docusaurus-plugin-llms to ^0.4.0 (#5637)" by @thomhurst in thomhurst/TUnit#5640 * fix(asp-net): forward disposal in FlowSuppressingHostedService (#5651) by @JohnVerheij in thomhurst/TUnit#5652 ### Dependencies * chore(deps): update dependency docusaurus-plugin-llms to ^0.4.0 by @thomhurst in thomhurst/TUnit#5637 * chore(deps): update tunit to 1.37.10 by @thomhurst in thomhurst/TUnit#5639 * chore(deps): update opentelemetry to 1.15.3 by @thomhurst in thomhurst/TUnit#5645 * chore(deps): update opentelemetry by @thomhurst in thomhurst/TUnit#5647 * chore(deps): update dependency dompurify to v3.4.1 by @thomhurst in thomhurst/TUnit#5648 * chore(deps): update dependency system.commandline to 2.0.7 by @thomhurst in thomhurst/TUnit#5650 * chore(deps): update dependency microsoft.entityframeworkcore to 10.0.7 by @thomhurst in thomhurst/TUnit#5649 * chore(deps): update dependency microsoft.templateengine.authoring.cli to v10.0.203 by @thomhurst in thomhurst/TUnit#5653 * chore(deps): update dependency microsoft.templateengine.authoring.templateverifier to 10.0.203 by @thomhurst in thomhurst/TUnit#5654 **Full Changelog**: thomhurst/TUnit@v1.37.10...v1.37.24 Commits viewable in [compare view](thomhurst/TUnit@v1.37.10...v1.39.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
1.37.24→1.37.361.37.24→1.37.361.37.24→1.37.361.37.24→1.37.361.37.24→1.37.361.37.24→1.37.361.37.24→1.37.36Release Notes
thomhurst/TUnit (TUnit)
v1.37.36: 1.37.36What's Changed
Other Changes
Full Changelog: v1.37.35...v1.37.36
v1.37.35: 1.37.35What's Changed
Other Changes
Dependencies
New Contributors
Full Changelog: v1.37.24...v1.37.35
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.