[BREAKING] delete should return boolean, set should throw TypeError#3
Merged
thoov merged 2 commits intothoov:masterfrom Mar 6, 2016
Merged
[BREAKING] delete should return boolean, set should throw TypeError#3thoov merged 2 commits intothoov:masterfrom
thoov merged 2 commits intothoov:masterfrom
Conversation
jasonmit
changed the title
jasonmit
changed the title
jasonmit
force-pushed
the
delete-returns-bool
branch
from
0c772a1 to
4d44fc6
Compare
Merged
|
👍 |
Owner
|
🎈 |
thoov
added a commit
that referenced
this pull request
Mar 6, 2016
[BREAKING] delete should return boolean, set should throw TypeError
|
looks like the private one in ember has also fixed this: emberjs/ember.js@bce8ed3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deletereturns boolean based on spec https://tc39.github.io/ecma262/#sec-weakmap.prototype.deletesetshould throwTypeErrorhttps://tc39.github.io/ecma262/#sec-weakmap.prototype.setimport Weakmap from 'ember-weakmap';WeakMapis available it will use that otherwise export the polyfillShould be version as a breaking change.