Conversation
|
I've been playing around with this for the past few days, and it's incredibly fun! 🎉 Also, could you update the beta tag to |
|
Yay! Thanks for doing this. I think it's a big enough conceptual change it should probably go in after v1, if not just so that we can highlight the new functionality and it not get lost in other changes. But I'm still thinking this through! |
|
Thanks! That makes sense. That said, since My application really depends on both |
|
The code change is small, but it's a big (positive) step in functionality which makes a nice highlight for a next release. I'm just trying to see if I can draw a line and get v1 done, as I've dragged my feet on it much longer than I was hoping I'd do. I appreciate this makes things annoying for you and your application though 😭 |
|
Thank you! I really appreciate it. I’m looking forward to the completion of v1. 😊 |
pablobm
left a comment
There was a problem hiding this comment.
Looking great! 🙂 Let some minor comments and after that I think this is a good first feature for the post-v1 release.
Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com>
|
@pablobm |
pablobm
left a comment
There was a problem hiding this comment.
I think this is good, just the minor comments. The one thing that I think is missing is simple tests to check that the example looks are working. I would write something like spec/example_app/spec/features/field_looks_spec.rb and examples checking some simple HTML: the <img> tags and the <optgroup> tag should do the trick.
Note that I would put these under spec/example_app/spec instead of under spec because they are things that I think users of Administrate should be testing when they customise their dashboards (it's their own code!), as opposed to things that Administrate should guarantee.
Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com>
Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com>
|
@pablobm (The failing tests are due to a separate Ruby 4–related issue.) |

Introduces a custom look implementation based on the discussion in #2291.
Changes:
lookoption toFieldBaseFieldBaseFieldlookoption to generatorsBelongsTolook in demo appproduct: Field::BelongsTo.with_options(look: :product_card)Please review and let me know if any changes are needed! 🚀
Usage:
/admin/pages/admin/orders/:id