Merged
Conversation
Collaborator
Author
|
@nickcharlton - Pinging you for a look even if this probably shouldn't be merged yet. In my view, this should be done closer to releasing v1.0. Perhaps as the last item. |
Closed
Member
|
Nice, looks good! I'll look into merging just before cutting the release. |
Collaborator
Author
|
Thinking again: perhaps this should be merged a bit earlier. Gems versioned 1.x-pre probably should have the API expected of v1.0.0, which includes removing these deprecated APIs. |
Member
|
If you think it's ready to go now, we can merge it now. The thing that's holding me back is running through some long and tedious regression testing and assuming we don't find anything (I suspect we won't), we're good to cut v1. |
rdunlop
added a commit
to rdunlop/administrate_exportable
that referenced
this pull request
Dec 31, 2025
They removed deprecated APIs thoughtbot/administrate#2832. The deprecation recommends these changes as recommended updates. https://github.com/thoughtbot/administrate/pull/1941/changes This appears to also address concerns listed here SourceLabsLLC#48
andreibondarev
added a commit
to SourceLabsLLC/administrate_exportable
that referenced
this pull request
Feb 7, 2026
They removed deprecated APIs thoughtbot/administrate#2832. The deprecation recommends these changes as recommended updates. https://github.com/thoughtbot/administrate/pull/1941/changes This appears to also address concerns listed here #48 Co-authored-by: Andrei Bondarev <andrei.bondarev13@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2815
Before going into v1.0, we should shed deprecated APIs that we have supported for back-compatibility.