Conversation
tysongach
commented
Feb 5, 2017
tysongach
commented
- Put component-specific variables in its partial
- Component-specific variables are variables that are used only for one component. They are unique from global variables in this way.
- They should be prefixed by one underscore to indicate that they are “private” to the component/partial they are defined within.
- Closes Rethinking what a variable is in Bitters #267
- Simplify input focus box-shadow
| @@ -1,3 +1,6 @@ | |||
| $_form-box-shadow: inset 0 1px 3px rgba(#000, 0.06); | |||
There was a problem hiding this comment.
Color literals like rgba(#000, 0.06) should only be used in variable declarations; they should be referred to via variable everywhere else.
There was a problem hiding this comment.
Should we be aiming to squash all these? It's frustrating to have a bunch of Hound comments on a bitters install.
There was a problem hiding this comment.
It’d be nice to not have that happen, yeah. Do you want to open a PR for #260?
| @@ -1,3 +1,6 @@ | |||
| $_form-box-shadow: inset 0 1px 3px rgba(#000, 0.06); | |||
There was a problem hiding this comment.
Color literals like rgba(#000, 0.06) should only be used in variable declarations; they should be referred to via variable everywhere else.
|
Is |
Yeah, I really meant component/object/element/partial… |
tysongach
force-pushed
the
tg-form-variables
branch
from
5d18da9 to
2625324
Compare
|
lgtm |
- Component-specific variables are variables that are used only for one component. They are unique from global variables in this way. - They should be prefixed by one underscore to indicate that they are "private" to the component/partial they are defined within. - Closes #267
tysongach
force-pushed
the
tg-form-variables
branch
from
6be804a to
27a7eb2
Compare
ghost
mentioned this pull request
4 participants
