Conversation
|
LGTM 👍 |
Contributor
|
Would have thought this was part of normalize but it's not. Wild. 💯 |
Contributor
Author
@kylefiedler It was until normalize.css 6.0, which was just released last week. They are trying to be less opinionated and focused on consistency of styling. |
normalize.css <6.0.0 set the `margin` to `0` on `body`. normalize 6.0.0 removed this, along with other opinionated rules. See: necolas/normalize.css@b5f0e9d
tysongach
force-pushed
the
tg-body-margin
branch
from
bb4669e to
6059fb2
Compare
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalize.css <6.0.0 set the
marginto0onbody. normalize 6.0.0removed this, along with other opinionated rules.
See: necolas/normalize.css@b5f0e9d