Conversation
houndci-bot
reviewed
Apr 22, 2017
| a { | ||
| color: $action-color; | ||
| text-decoration: none; | ||
| text-decoration-skip: ink; |
There was a problem hiding this comment.
Unknown property text-decoration-skip
Contributor
Author
There was a problem hiding this comment.
Contributor
|
like |
Styling links only through color and removing their default underline is an accessibility concern for people with color blindness. It's possible they would not be able to discern the difference between regular text and a link. This commit also sets the `text-decoration-skip` property to `ink` for all links, which only draws text decoration where it does not touch or closely approach a glyph.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styling links only through color and removing their default underline
is an accessibility concern for people with color blindness. It's
possible they would not be able to discern the difference between
regular text and a link.
This commit also sets the
text-decoration-skipproperty toinkforall links, which only draws text decoration where it does not touch or
closely approach a glyph.
text-decoration-skipis support in most browsers with a prefix, excluding IE & Edge: http://caniuse.com/#feat=text-decoration