Conversation
houndci-bot
reviewed
May 25, 2017
|
|
||
| th, | ||
| td { | ||
| padding: $small-spacing $small-spacing $small-spacing 0; |
There was a problem hiding this comment.
Shorthands of length 4 are not allowed. Value was $small-spacing $small-spacing $small-spacing 0
Contributor
Author
There was a problem hiding this comment.
This is bad guidance. The best way to achieve this padding is via that shorthand (versus long-hand of margin-top, margin-right, etc.). Just because I need 0 for margin-left doesn’t mean I should be throwing off our linter. I’ve adjusted scss-lint (and Hound in return) in ca1aea7.
|
👍 |
kylefiedler
reviewed
May 25, 2017
contrib/index.html
Outdated
| <td>Division 1</td> | ||
| <td> | ||
| Division 2 with some even longer text that seems to just ramble on | ||
| and on… |
Contributor
There was a problem hiding this comment.
Should we have a proper ellipsis? …
kylefiedler
approved these changes
May 25, 2017
Contributor
kylefiedler
left a comment
kylefiedler
left a comment
There was a problem hiding this comment.
Small comment. Otherwise ⛵️
- Increase bottom and top margin on tables
- This matches the same bottom and top margin values we set on `hr`
elements.
- Move `text-align` property to `table`
- In most situations, left-aligned text within a table is ideal. This
makes sure the whole table is left-aligned, while still allowing
easy overriding on a per-column basis (e.g. for numeral data).
- Change vertical alignment of tables
- Vertically aligning cell text in the middle makes for a bad reading
experience because there is no consistent or expected starting point
for text that the eyes can pick up on.
- This changes the vertical alignment of cell text to:
- Bottom of the cell in the table header (`thead`)
- Top of the cell in the table body (`tbody`)
- Set table borders on the row
- Rather than setting borders on each individual cell, this sets it on
the whole row (`tr`).
- Use the headings line-height in table headers
- Add padding to the right of each table cell
- This prevents adjacement cell text from butting into each other.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve been working on a few table-heavy projects lately and I’ve found that the base table styles that Bitters provided me left a lot to be desired. Specifically, if the table has decently long strings of text within it, the layout really fell apart and made for a painful reading experience. This PR updates the table styles with a new niceties which I think makes a great starting point for nearly all tables, and also updates the contributing page markup to include some longer text within the cells.
hrelements.text-alignproperty totablethead)tbody)tr).Before
After