Disconnect $base-spacing from $base-line-height#292
Merged
Conversation
mjankowski
approved these changes
Jun 27, 2017
Contributor
|
🚢 |
The two serve different purposes and their values don't need to be relational. Also, since we do not facilitate or support a vertical rhythm, the two variables do not need to be connected. One situation where I've found this to be problematic (when they are connected) is when I want to tweak the line height for a specific typeface, but I don't want that change to manipulate spacing throughout the whole application.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two serve different purposes and their values don't need to be
relational. Also, since we do not facilitate or support a vertical
rhythm, the two variables do not need to be connected.
One situation where I've found this to be problematic (when they are
connected) is when I want to tweak the line height for a specific
typeface, but I don't want that change to manipulate spacing throughout
the whole application.