Skip to content

make sure ips r valid while asking for registration #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashraffouda merged 1 commit into from
Feb 26, 2026
Merged

make sure ips r valid while asking for registration #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/registrar/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,12 @@ func registerNode(
var ips []string
for _, ip := range zosIps {
ipV := net.IP(ip)
ips = append(ips, ipV.String())
s := ipV.String()
if net.ParseIP(s) == nil {
log.Warn().Str("ip", s).Msg("skipping invalid IP from zos bridge")
continue
}
ips = append(ips, s)
}
return ips
}(),
Expand Down
9 changes: 7 additions & 2 deletions pkg/registrar_light/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"crypto/ed25519"
"fmt"
"net"
"time"

"github.com/centrifuge/go-substrate-rpc-client/v4/types"
Expand Down Expand Up @@ -121,8 +122,12 @@ func registerNode(
IPs: func() []string {
ips := make([]string, 0)
for _, ip := range infs.Interfaces["zos"].IPs {

ips = append(ips, ip.IP.String())
s := ip.IP.String()
if net.ParseIP(s) == nil {
log.Warn().Str("ip", s).Msg("skipping invalid IP from zos bridge")
continue
}
ips = append(ips, s)
}
return ips
}(),
Expand Down
Loading