failing to parse toml multi-line string fields that have double quotes inside

[abom]

.startup.toml contains a multu-line field that contains double quoted string inside..

When the container starts, it gives invalid TOML syntax.

Contents of /var/cache/containers/<id>/container.log (thanks @muhamadazmy for pointing me to this!).

Version: development @Revision: 73b9b038f2c549d478adf7b97a1f3a2662c36f7e
2019/06/09 15:26:15 bootstrap D > setting up mounts
2019/06/09 15:26:15 manager D > initializing manager
2019/06/09 15:26:15 main I > Starting process manager
2019/06/09 15:26:15 main I > magic recieved .. continue coreX bootstraping
2019/06/09 15:26:15 bootstrap D > setting up hostname
2019/06/09 15:26:15 bootstrap I > Set hostname to corex
2019/06/09 15:26:15 bootstrap D > linkin mtab
2019/06/09 15:26:15 bootstrap D > startup services
2019/06/09 15:26:15 bootstrap E > failed to load plugins: open /.plugin.toml: no such file or directory
2019/06/09 15:26:15 bootstrap E > failed to startup container services: line 7: invalid TOML syntax

As 0-core uses https://github.com/naoina/toml, i tested it separately, and it gave the same error, while other toml parsers like https://github.com/BurntSushi/toml didn't.

[muhamadazmy]

This is a toml limitation. A double quote is not supported inside a multi line string. U have 2 options, either skip each double quote with a \. Or the better option is to move the bash script to a file and then the toml can just call the script. We already do this in lots of places where it's needed.

…

On Sun, Jun 9, 2019, 6:56 PM Abdelrahman Ghanem ***@***.***> wrote: .startup.toml contains a multu-line field that contains double quoted string inside. <https://github.com/threefoldtech/jumpscaleX/blob/ea5e7530beae00e8bab63322186ca670eee55fb9/Jumpscale/builder/db/templates/postgres_startup.toml> . When the container starts, it gives invalid TOML syntax. Contents of /var/cache/containers/<id>/container.log (thanks @muhamadazmy <https://github.com/muhamadazmy> for pointing me to this!). Version: development @revision: 73b9b03 2019/06/09 15:26:15 bootstrap D > setting up mounts 2019/06/09 15:26:15 manager D > initializing manager 2019/06/09 15:26:15 main I > Starting process manager 2019/06/09 15:26:15 main I > magic recieved .. continue coreX bootstraping 2019/06/09 15:26:15 bootstrap D > setting up hostname 2019/06/09 15:26:15 bootstrap I > Set hostname to corex 2019/06/09 15:26:15 bootstrap D > linkin mtab 2019/06/09 15:26:15 bootstrap D > startup services 2019/06/09 15:26:15 bootstrap E > failed to load plugins: open /.plugin.toml: no such file or directory 2019/06/09 15:26:15 bootstrap E > failed to startup container services: line 7: invalid TOML syntax As 0-core uses https://github.com/naoina/toml, i tested it separately, and it gave the same error, while other toml parsers like https://github.com/BurntSushi/toml didn't. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACTKDAZRATLEJAXBJANEDVTPZUY5RANCNFSM4HWK7EWQ> .

[abom]

Thanks for pointing out these two options, the second one is way better for sure and i will use it, but i think TOML doesn't limit this.

From Multi-line basic strings:

Any Unicode character may be used except those that must be escaped: backslash and the control characters (U+0000 to U+001F, U+007F). Quotation marks need not be escaped unless their presence would create a premature closing delimiter.

A single double quotation is not a premature closing delimiter .