Validate role-tagged covenant approvals#3890
Merged
mswilkison merged 1 commit intofeat/psbt-covenant-final-project-prfrom Mar 13, 2026
Merged
Validate role-tagged covenant approvals#3890mswilkison merged 1 commit intofeat/psbt-covenant-final-project-prfrom
mswilkison merged 1 commit intofeat/psbt-covenant-final-project-prfrom
Conversation
mswilkison
changed the base branch from
codex/psbt-covenant-signer-hardening
to
feat/psbt-covenant-final-project-pr
mswilkison
force-pushed
the
codex/psbt-covenant-approval-envelope
branch
from
54f1297 to
a246ad0
Compare
mswilkison
merged commit 7d4beff
into
feat/psbt-covenant-final-project-pr
15 checks passed
mswilkison
added a commit
that referenced
this pull request
Mar 13, 2026
## Summary - normalize covenant signer requests before digesting and storing them - canonicalize artifact approval order and derived legacy signatures when approvals are present - add regressions proving equivalent request variants hash the same, poll successfully, and persist in canonical form ## Testing - go test ./pkg/covenantsigner - go test ./pkg/tbtc -run CovenantSigner -count=1 ## Notes - stacked on top of #3890 - this keeps submit/poll matching semantic for approval envelopes without changing the cryptographic verification model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Notes