Skip to content

Differentiate self_v1 presign and reconstruction requests#3900

Merged
mswilkison merged 3 commits intocodex/psbt-covenant-signer-approval-cutoverfrom
codex/psbt-covenant-selfv1-request-type
Mar 13, 2026
Merged

Differentiate self_v1 presign and reconstruction requests#3900
mswilkison merged 3 commits intocodex/psbt-covenant-signer-approval-cutoverfrom
codex/psbt-covenant-selfv1-request-type

Conversation

@mswilkison
Copy link

Summary

  • add requestType to covenant signer requests and make it part of normalization and request digests
  • reject invalid qc_v1 + presign_self_v1 combinations while preserving explicit self_v1 presign semantics
  • refresh mirrored approval-contract vectors and add requestType regressions in covenantsigner and tbtc engine tests

Testing

  • go test ./pkg/covenantsigner ./pkg/tbtc -run 'SignerApprovalCertificate|CovenantSigner|ApprovalContractVectors|RequestDigestDistinguishesSelfV1PresignFromReconstruct|RejectsQcV1PresignRequestType' -count=1

@mswilkison mswilkison merged commit ad3d0cb into codex/psbt-covenant-signer-approval-cutover Mar 13, 2026
15 checks passed
@mswilkison mswilkison deleted the codex/psbt-covenant-selfv1-request-type branch March 13, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant