Video Player preferences playing mode (InApp, InAppBrowser,External) #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
force-pushed
the
enhancement/video_player_mode
branch
from
cc717dc to
5bdbdec
Compare
hjiangsu
approved these changes
Nov 27, 2024
Member
hjiangsu
left a comment
hjiangsu
left a comment
There was a problem hiding this comment.
LGTM! I just made a couple of slight adjustments to the implementation:
- Rebased branch to sync up with the latest
developchanges - Simplified the logic for handling external app/custom tabs to make it more readable
- Minor linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Video Player preferences playing mode (InApp, InAppBrowser,External).
This applies to both players.
Issue Being Fixed
Issue Number: #1517
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?