Skip to content

Feature/identify default theme #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hjiangsu merged 3 commits into from
Aug 15, 2023
Merged

Feature/identify default theme #611

hjiangsu merged 3 commits into from
Aug 15, 2023

Conversation

@micahmo
Copy link
Member

@micahmo micahmo commented Aug 10, 2023 •
edited
Loading

Pull Request Description

This PR changes the label of the default accent color to clearly indicate that it's the default. It is also now placed at the top of the list.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

image

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable? -- N/A
  • Did you add semanticLabels where applicable for accessibility? -- N/A

hjiangsu
hjiangsu approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll merge this in after the general release version is built and released

@hjiangsu hjiangsu merged commit 7a59471 into thunder-app:develop Aug 15, 2023
@micahmo micahmo deleted the feature/identify-default-theme branch August 15, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@micahmo @hjiangsu