chore(state-machine): add support for dispacthing ui side effects from state side effects#10805
Open
rafaeltonholo wants to merge 5 commits intothunderbird:mainfrom
Open
Conversation
- Update `StateSideEffectHandler` and its `Factory` to include a third generic type `TEffect`. - Add `dispatchUiEffect` to `StateSideEffectHandler` to allow side effect handlers to trigger UI effects. - Update `BaseStateMachineViewModel` and associated tests to support the updated factory and handler signatures.
…ttern - Changed `StateSideEffectHandler.accept()` to receive both `oldState` and `newState` parameters - Renamed `handle()` to `consume()` and updated return type to `ConsumeResult` - Updated `accept()` to check for state changes (`oldState != newState`) where appropriate - Modified all side effect handlers and tests to use new `consume()` pattern - Updated `BaseStateMachineViewModel` to call `handle()` on all side effect handlers regardless of acceptance - Removed redundant state transition in `SetupWarmingUpInitialState`
…deEffectHandlerTest`
rafaeltonholo
added
the
report: exclude
github-actions
bot
added
the
tb-team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10775.
feature-flag:
enable_message_list_new_stateStateSideEffectHandlerand itsFactoryto include a third generic typeTEffect.dispatchUiEffecttoStateSideEffectHandlerto allow side effect handlers to trigger UI effects.BaseStateMachineViewModeland associated tests to support the updated factory and handler signatures.