refactor(message-list): reestructure composables to use atomic design and include scroll events handling#10810
Open
rafaeltonholo wants to merge 3 commits intothunderbird:mainfrom
Conversation
rafaeltonholo
added
the
report: exclude
github-actions
bot
added
the
tb-team
Contributor
|
Missing report label. Set exactly one of: |
…stScope Introduced `MessageListScope` to enable controlled scrolling to messages from external callers (e.g., effect handlers). - Added `MessageListScope` interface with `scrollToMessage()` method and `scrollEvents` flow. - Created `ScrollToMessage` effect in `MessageListEffect`. - Updated `MessageListScreenRenderer.Render()` to require `MessageListScope` receiver. - Connected scroll events to `LazyColumn` in `MessageListPage` using `LifecycleStartEffect`.
…omposable - Extracted scroll event effect logic into `ScrollEventEffect` composable function - Added configuration restoration logic to scroll to active message when list state is restored - Simplified `MessageList` composable by delegating scroll handling to `ScrollEventEffect`
rafaeltonholo
force-pushed
the
refactor/10775/message-list-components-reestructure
branch
from
0fd6e5d to
fc1e88d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10775.
feature-flag:
enable_message_list_new_stateMessageListScope