Remove SHUSH/--no-log compat; migrate store v2→v3; fix agent start and e2e script#22
Merged
cursor[bot] merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
…cript - Drop SHUSH_* and deprecated --no-log; document only ONESSH agent env vars. - Start background agent with both ONESSH_AGENT_CAPABILITY and SHUSH_CAPABILITY so the child process matches the parent without reading SHUSH from the parent env. - Accept older meta.yaml store version 2 and upgrade to 3 on successful unlock. - Add logout --all using passphrase key prefix clear (fixes unit test). - Fix e2e TTY helper for util-linux script(1) argument parsing. Co-authored-by: lbb <mr@lbb00.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes legacy compatibility paths the user asked to drop, adds downward-compatible handling for store metadata versions, and fixes regressions uncovered during testing.
Changes
Environment / CLI
SHUSH_SOCKET/SHUSH_CAPABILITYfallbacks and the deprecated hidden--no-logflag.ONESSH_AGENT_SOCKETandONESSH_AGENT_CAPABILITY.Agent subprocess
agent startnow mirrors the library behavior by setting bothONESSH_AGENT_CAPABILITYand the shush-required capability env on the child process, so the server and CLI agree without reintroducing parent-sideSHUSH_*reads.Encrypted store
internal/store/version.go.[2, 3]; unlocking a v2meta.yamlrewrites it to v3 on disk.[1, 1]) with room to extendMin/Writewhen future formats appear.logout --all--allto clear only OneSSH passphrase cache keys (onessh:passphrase:v1:prefix) viaClearPrefix, matching the existing unit test expectations.E2E
runWithTTYfor util-linuxscript(1)so-cis not consumed byscriptinstead ofsh.Testing
go test ./...