fix(voice): create ElevenLabs tools before agent setup#464
Open
Shujakuinkuraudo wants to merge 1 commit intotiann:mainfrom
Open
fix(voice): create ElevenLabs tools before agent setup#464Shujakuinkuraudo wants to merge 1 commit intotiann:mainfrom
Shujakuinkuraudo wants to merge 1 commit intotiann:mainfrom
Conversation
There was a problem hiding this comment.
Findings
- [Major] Auto-discovery now hard-fails without ConvAI write scope —
getOrCreateAgentId()now treats tool creation and agent patching as mandatory before it will return an existing agent ID, so installations that rely onELEVENLABS_API_KEYonly can start returningFailed to create ElevenLabs agent automaticallyeven when the agent already exists and token minting would otherwise be possible. Evidencehub/src/web/routes/voice.ts:203,hub/src/web/routes/voice.ts:217.
Summary
- Review mode: initial
- 1 finding. The new auto-provisioning path turns token issuance into a write operation for existing agents, which is a regression for accounts without ConvAI write permission.
- Residual risk: Not found in repo/docs: automated coverage for the write-denied / existing-agent path.
Testing
- Not run (automation; untrusted PR code)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt.toolsusage withprompt.tool_idsTesting
createOrUpdateHapiAgent()succeeds with an ElevenLabs key that has ConvAI write accessmessageCodingAgentandprocessPermissionRequestbun run build:single-exe