fix(cli): include ~/.codex/skills in user skill discovery#487
Merged
Conversation
The skill listing only scanned ~/.agents/skills and ~/.claude/skills for user-level skills, ignoring ~/.codex/skills where Codex users commonly store their skills. Add ~/.codex/skills to getUserSkillsRoots() so these skills appear in the web UI $ autocomplete. Hidden directories (starting with .) inside the skills root are still skipped (e.g., .system/). via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run>
Deploying hapi with
|
| Latest commit: |
4f53162
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c663ce59.hapi-bqd.pages.dev |
| Branch Preview URL: | https://fix-codex-skills-discovery.hapi-bqd.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review mode: initial
No diff-linked issues found in cli/src/modules/common/skills.ts:24 and cli/src/modules/common/skills.test.ts:72.
Residual risk: the updated test covers discovery from ~/.codex/skills and hidden-directory skipping, but it does not explicitly cover duplicate-name precedence between ~/.claude/skills and ~/.codex/skills; current behavior still depends on root order in cli/src/modules/common/skills.ts:26.
Testing: Not run (automation). bun is not installed in this runner, so bun test cli/src/modules/common/skills.test.ts could not be executed.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.codex/skillstogetUserSkillsRoots()so Codex users' skills are discovered by the web UI$autocomplete~/.agents/skillsand~/.claude/skillswere scanned;~/.codex/skillswas intentionally excluded as "legacy" but users actively store skills there.system/etc.) inside skills roots are still skipped by the existingentry.name.startsWith('.')check.agents>.claude>.codex(first found wins for duplicate names)Closes #482
Test plan
~/.codex/skillsskills are now included in listing.system/) are still excluded~/.agents/skillsand~/.claude/skillsbehavior unchanged