move the defaults to where the flags are defined so the user knows what ... #1
Conversation
This includes three new commandline flags to control this behavior, for those who don't want the default (which is currently automount `/Users` for OS X, and automount `C:\Users` for Windows, but will change to automount `homeDir()` at some point in the future): - `--vbox-share=true: Enable VirtualBox share creation during 'init'` - `--vbox-share-dir="": Change VirtualBox shared folder created during 'init' from the default autodetection logic` - `--vbox-share-name="": Change VirtualBox shared folder name created during 'init' from the default of being automatically determined based on the share directory path`
…at the values look like, and report at least one error
There was a problem hiding this comment.
Inadvertent, or trying to sneak in a change to the default value? 😈
There was a problem hiding this comment.
perhaps you want to read the rest of the diff?
as your case statement only covers very few GOOS options, and then only the ones that might be true, defaulting to false is the most portable....
There was a problem hiding this comment.
Right, but if the "share directory" is empty, we don't even try sharing.
So with this, the experience on Linux goes from "boot2docker
--vbox-share-dir=/home --vbox-share-name=Users" to the much more verbose
"boot2docker --vbox-share=true --vbox-share-dir=/home
--vbox-share-name=Users", when there isn't really a great reason for it
that I can see for the inconsistency, unless I'm missing something.
Otherwise, I'm +1 on this change and totally agree that it helps with
increasing visibility on the default behavior immensely.
There was a problem hiding this comment.
thats a very EW way to quietly toggle the boolean.
its horribly inconsistent to say
--vbox-share=true --vbox-share-dir=""- imo that should be an error condition, not a silent change to the bool.
essentially, if you want to toggle based on the dir string, then don't provide an enable bool.
I prefer the bool to mean what it says.
There was a problem hiding this comment.
mmm, after thinking a little more - i still think we want to make it false for all the other platforms, and we can do something nicer for windows in the next week.
this entire thing is a compromise..
tianon
force-pushed
the
vbox-sharing
branch
2 times, most recently
from
081a853 to
b161571
Compare
2 participants
...the values look like, and report at least one error
merge me!