refactor(ai): tighten openai-chat typing without base extraction#93
Merged
refactor(ai): tighten openai-chat typing without base extraction#93
Conversation
added 2 commits
April 10, 2026 11:18
Apply typed request/response guards directly in openai-chat-completion and remove any usage in the provider implementation. Add provider-focused tests and clarify config comments for OpenAI-compatible endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked from #92 — type-safety improvements only, without the unrelated plugin id change.
OpenAIChatCompletionProvider: typed interfaces (APIMessage,RequestBody,AssistantSessionMessage,ToolCallResponse), type guards (isErrorResponseBody,hasNonEmptyChoices),ProviderConfiginstead ofanyin constructor, propercontent: string | nullhandlingmaxIterations,iterationTimeout) in error messages instead of potentially-undefined config valuesfilterIncompleteToolCallSequenceswith properAIMessage[]typingopenai-chatworks for any OpenAI-compatible endpoint (DeepSeek, Groq, etc.)Original work by @regulusleow. Split from #92 to keep the plugin id change separate.