Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Fix negative numbers not working for boolean euclids #1063

Merged
matthewkaney merged 1 commit intotidalcycles:1.10-devfrom
geikha:1.10-dev
Mar 30, 2024
Merged

Fix negative numbers not working for boolean euclids #1063
matthewkaney merged 1 commit intotidalcycles:1.10-devfrom
geikha:1.10-dev

Conversation

@geikha
Copy link
Copy Markdown
Contributor

@geikha geikha commented Jan 19, 2024 •
edited
Loading

As you may remember, with #915 and #916, we added the possibility of using negative values for the first argument of euclidian rhythms. However we forgot to replicate this behaviour for boolean euclidian patterns.

This fixes the following bug I've encountered:

-- works
d1 $ mask "t(5,16)" $ s "808lt*16" |- note (saw*2) # shape 0.3 # octave 6

-- goes silent:
d1 $ mask "t(-5,16)" $ s "808lt*16" |- note (saw*2) # shape 0.3 # octave 6

@geikha
replicate euclid negative behaviour on bools
e7e0c59 
fixes stuff like `mask "t(-5,16)"` not work
@matthewkaney matthewkaney merged commit d130059 into tidalcycles:1.10-dev Mar 30, 2024
@matthewkaney
Copy link
Copy Markdown
Collaborator

matthewkaney commented Mar 30, 2024

Looks good to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geikha @matthewkaney