Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Add listener build workflows#852

Merged
yaxu merged 2 commits intotidalcycles:mainfrom
ndr-brt:build-workflows
Nov 1, 2021
Merged

Add listener build workflows#852
yaxu merged 2 commits intotidalcycles:mainfrom
ndr-brt:build-workflows

Conversation

@ndr-brt
Copy link
Copy Markdown
Contributor

@ndr-brt ndr-brt commented Oct 17, 2021

Ref #850 and #315
Adapted from https://github.com/polymorphicengine/tidal-gui
They will run only after a tag with the format *.*.*, so only after a tidal release.
Tested on my fork.

@yaxu
Copy link
Copy Markdown
Member

yaxu commented Oct 18, 2021

Excellent!

@ndr-brt
Copy link
Copy Markdown
Contributor Author

ndr-brt commented Oct 18, 2021

Ok, I noticed that the branch was not rebased to main, I updated it

@yaxu yaxu merged commit f4caed5 into tidalcycles:main Nov 1, 2021
@yaxu
Copy link
Copy Markdown
Member

yaxu commented Nov 1, 2021

Thanks :)

@yaxu
Copy link
Copy Markdown
Member

yaxu commented Nov 7, 2021

So @ndr-brt how does this work, where do the binaries end up? Are we able to trigger this without doing a release, for testing things out?

@ndr-brt
Copy link
Copy Markdown
Contributor Author

ndr-brt commented Nov 7, 2021

If I remember well, the release action needs a tag to be executed, so it creates a release with the binaries in the "releases" section. Maybe @polymorphicengine can correct me if I'm wrong

@ndr-brt
Copy link
Copy Markdown
Contributor Author

ndr-brt commented Nov 7, 2021

To test that maybe we could make that run at every push, not only when there's a tag, then set the release step to run only when there's a tag

@polymorphicengine
Copy link
Copy Markdown
Collaborator

yes that's correct. To try it out just change it to

on:
  push:
    branches: [ main ]

I don't know how to conditionally run a step when there is a tag from the top of my head but it should be possible.

@ndr-brt ndr-brt deleted the build-workflows branch November 8, 2021 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants