Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Import safe-tidal-cli ghci simulator as tidal binary#880

Merged
yaxu merged 4 commits intomainfrom
topic-ghci-simulator
Dec 27, 2021
Merged

Import safe-tidal-cli ghci simulator as tidal binary#880
yaxu merged 4 commits intomainfrom
topic-ghci-simulator

Conversation

@yaxu
Copy link
Copy Markdown
Member

@yaxu yaxu commented Dec 27, 2021

@yaxu
Copy link
Copy Markdown
Member Author

yaxu commented Dec 27, 2021

@jwaldmann How do you feel about this? Hope you don't mind, I thought safe-tidal-cli would make an excellent default tidal 'binary' and am giving it a go here.. I just adjusted the code block detection, so it can be a drop-in ghci replacement.

@jwaldmann
Copy link
Copy Markdown
Contributor

Yes fine. I'm glad you find this useful.

On code block detection: "ghci-like" (what you implemented) means that a code block is

  • a single line (so, delimited by \n)
  • or several lines in :{' .. ':} ?

That's incompatible with "for flok" (what I had) where a code block is

  • several lines, delimited by a blank line (so, \n\n)

Too bad that's incompatible. Perhaps make it switchable via command line option?

@yaxu
Copy link
Copy Markdown
Member Author

yaxu commented Dec 27, 2021

Great thanks!

Hm, I believe flok does wrap with :{ :}:

https://github.com/munshkr/flok/blob/main/packages/repl/src/repl/tidal.ts#L16

But no problem to add the option if it's useful.

@yaxu yaxu merged commit 2342279 into main Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants